From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
linux-iio <linux-iio@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Luca Coelho <luciano.coelho@intel.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Christoph Hellwig <hch@lst.de>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Sagi Grimberg <sagi@grimberg.me>,
Sujith Thomas <sujith.thomas@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Darren Hart <dvhart@infradead.org>,
Zhang Rui <rui.zhang@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Johannes Berg <johannes.berg@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Intel Linux Wireless <linuxwifi@intel.com>,
Jens Axboe <axboe@fb.com>, Keith Busch <kbusch@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
linux-hwmon@vger.kernel.org,
"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH v3 00/12] add header file for kelvin to/from Celsius conversion helpers
Date: Wed, 11 Dec 2019 17:34:37 +0200 [thread overview]
Message-ID: <CAHp75VcsfbkG7n6FHkpnPN0sG_PdKg_iKS7VGfATxuPVYU5jcQ@mail.gmail.com> (raw)
In-Reply-To: <1576075099-3441-1-git-send-email-akinobu.mita@gmail.com>
On Wed, Dec 11, 2019 at 4:38 PM Akinobu Mita <akinobu.mita@gmail.com> wrote:
>
> There are several helper macros to convert kelvin to/from Celsius in
> <linux/thermal.h> for thermal drivers. These are useful for any other
> drivers or subsystems, but it's odd to include <linux/thermal.h> just for
> the helpers.
>
> This adds a new <linux/units.h> that provides the equivalent inline
> functions for any drivers or subsystems, and switches all the users of
> conversion helpers in <linux/thermal.h> to use <linux/units.h>
> helpers.
>
Thank you for an update.
For non-commented patches
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> * v3
> - rename new header name from <linux/temperature.h> to <linux/units.h>
> - add milli_kelvin_to_millicelsius() and millicelsius_to_milli_kelvin() and
> use them for implementing other helpers
> - add MILLIDEGREE_PER_DEGREE and MILLIDEGREE_PER_DECIDEGREE and replace
> the hardcoded constants
> - add kelvin_to_celsius() and celsius_to_kelvin() in <linux/units.h>
> - add Reviewed-by tags
> - switch iwlegacy driver to use <linux/units.h> helpers
> - switch iwlwifi driver to use <linux/units.h> helpers
> - remove unused TO_MCELSIUS macro in armada thermal driver
> - switch qcom-vadc-common module to use <linux/units.h> helpers
>
> * v2
> - add deci_kelvin_to_millicelsius_with_offset() in linux/temperature.h
> - stop including linux/temperature.h from linux/thermal.h
> - include <linux/temperature.h> explicitly from thermal drivers
> - fix s/temprature/temperature/ typo in commit log
> - use deci_kelvin_to_millicelsius_with_offset() in ACPI thermal zone driver
> - don't mix up another fix (format string for cellsius value)
> - add Acked-by and Reviewed-by tags
>
> Akinobu Mita (12):
> add helpers for kelvin to/from Celsius conversion
> ACPI: thermal: switch to use <linux/units.h> helpers
> platform/x86: asus-wmi: switch to use <linux/units.h> helpers
> platform/x86: intel_menlow: switch to use <linux/units.h> helpers
> thermal: int340x: switch to use <linux/units.h> helpers
> thermal: intel_pch: switch to use <linux/units.h> helpers
> nvme: hwmon: switch to use <linux/units.h> helpers
> thermal: remove kelvin to/from Celsius conversion helpers from
> <linux/thermal.h>
> wireless: iwlegacy: use <linux/units.h> helpers
> wireless: iwlwifi: use <linux/units.h> helpers
> thermal: armada: remove unused TO_MCELSIUS macro
> iio: adc: qcom-vadc-common: use <linux/units.h> helpers
>
> drivers/acpi/thermal.c | 36 +++++-----
> drivers/iio/adc/qcom-vadc-common.c | 6 +-
> drivers/iio/adc/qcom-vadc-common.h | 1 -
> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +-
> drivers/net/wireless/intel/iwlegacy/4965.c | 11 +--
> drivers/net/wireless/intel/iwlegacy/common.h | 3 -
> drivers/net/wireless/intel/iwlwifi/dvm/dev.h | 5 --
> drivers/net/wireless/intel/iwlwifi/dvm/devices.c | 6 +-
> drivers/nvme/host/hwmon.c | 13 ++--
> drivers/platform/x86/asus-wmi.c | 7 +-
> drivers/platform/x86/intel_menlow.c | 9 ++-
> drivers/thermal/armada_thermal.c | 2 -
> .../intel/int340x_thermal/int340x_thermal_zone.c | 7 +-
> drivers/thermal/intel/intel_pch_thermal.c | 3 +-
> include/linux/thermal.h | 11 ---
> include/linux/units.h | 84 ++++++++++++++++++++++
> 16 files changed, 139 insertions(+), 68 deletions(-)
> create mode 100644 include/linux/units.h
>
> Cc: Sujith Thomas <sujith.thomas@intel.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amit.kucheria@verdurent.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Stanislaw Gruszka <sgruszka@redhat.com>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Cc: Intel Linux Wireless <linuxwifi@intel.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-12-11 15:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 14:38 [PATCH v3 00/12] add header file for kelvin to/from Celsius conversion helpers Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 01/12] add helpers for kelvin to/from Celsius conversion Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 02/12] ACPI: thermal: switch to use <linux/units.h> helpers Akinobu Mita
2019-12-11 15:29 ` Andy Shevchenko
2019-12-13 4:03 ` Akinobu Mita
2019-12-13 9:08 ` Andy Shevchenko
2019-12-11 14:38 ` [PATCH v3 03/12] platform/x86: asus-wmi: " Akinobu Mita
2019-12-11 15:31 ` Andy Shevchenko
2019-12-13 4:06 ` Akinobu Mita
2019-12-13 9:05 ` Andy Shevchenko
2019-12-11 14:38 ` [PATCH v3 04/12] platform/x86: intel_menlow: " Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 05/12] thermal: int340x: " Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 06/12] thermal: intel_pch: " Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 07/12] nvme: hwmon: " Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 08/12] thermal: remove kelvin to/from Celsius conversion helpers from <linux/thermal.h> Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 09/12] wireless: iwlegacy: use <linux/units.h> helpers Akinobu Mita
2019-12-12 9:35 ` Kalle Valo
2019-12-11 14:38 ` [PATCH v3 10/12] wireless: iwlwifi: " Akinobu Mita
2019-12-13 9:21 ` Luca Coelho
2019-12-11 14:38 ` [PATCH v3 11/12] thermal: armada: remove unused TO_MCELSIUS macro Akinobu Mita
2019-12-11 14:38 ` [PATCH v3 12/12] iio: adc: qcom-vadc-common: use <linux/units.h> helpers Akinobu Mita
2019-12-11 15:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcsfbkG7n6FHkpnPN0sG_PdKg_iKS7VGfATxuPVYU5jcQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=andy@infradead.org \
--cc=axboe@fb.com \
--cc=daniel.lezcano@linaro.org \
--cc=dvhart@infradead.org \
--cc=emmanuel.grumbach@intel.com \
--cc=hch@lst.de \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=johannes.berg@intel.com \
--cc=kbusch@kernel.org \
--cc=knaack.h@gmx.de \
--cc=kvalo@codeaurora.org \
--cc=lars@metafoo.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=rui.zhang@intel.com \
--cc=sagi@grimberg.me \
--cc=sgruszka@redhat.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).