From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7947CC432C0 for ; Sun, 24 Nov 2019 19:54:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FDBB207FD for ; Sun, 24 Nov 2019 19:54:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MMfV8DuN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N9k+kyqV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FDBB207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=muwfgYiMhrvpmM87aGfiDCvs9iivZP2G92jUEJGcOfI=; b=MMfV8DuNI9BbsU eYvySjyhDf5ukQK+r0zFc/OSIfxtNBWgvVwtDsiKrZVKkXL3hgIF/rOIi5s5p55EXlCxhAnqUNsdC T+b9T+EaNUqZyzKAvbqxx0rLW+e841UTXRwiNY5oHVTXZI/3nE+p20TJNj0B/9211t+msAjFH2iHc 8s3LmA82HsYOEoUjkYRBgD7xfI/BsZjwjzdHc/E3Q7muiuM9X/U1OYQA98/3uvjO5NuDOpg2rKqp+ PfX2wYC6us+ycmtJ6D5iggkBXwQRwL6TZ2ebAkvB8DjGkhjE5t65b9l526BLsourAnUU9Sc50bhlr uJKjb0s2F3IPzRsw970A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYxxz-0006OK-B2; Sun, 24 Nov 2019 19:54:43 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYxxv-0006NZ-KR for linux-nvme@lists.infradead.org; Sun, 24 Nov 2019 19:54:41 +0000 Received: by mail-pg1-x542.google.com with SMTP id b137so3658250pga.6 for ; Sun, 24 Nov 2019 11:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xgxN+slUElCQpDuU8fsY3BZMJxer4zKWxWFoQzMGtA4=; b=N9k+kyqVqvVAuU5pmVcD05y0P7ep7fkeAyzpfnA8hS2146dGHNMBjSFR9uiJV8PHu0 9aJTs33ZWmukHbhGxkM9JoSH+maOgpdQdyDSpGppnHZX79oYQ1DMEBvvya80yKdDrCRn UAhC+xeK8nbxYIHlDlIctzaYwHAhcTTcuw140chiI8mR8MQJetOiFzuSlX+qXYuNjuPC ALXFb25TaINXA4BSo6hqgC/27e33SJxaQdfegL7mzSgjFC+vMNyCowgMcV3yJvVEhnK/ XomI1mA4ZMdgY4R282CGbCovH0hL0rqqQ49vvktIoDg5pRbcoXH8+heiUYIo3ezzqGn8 h4QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xgxN+slUElCQpDuU8fsY3BZMJxer4zKWxWFoQzMGtA4=; b=nuynqp4Ic4bVdevNnr+8nkHfZsPCrtP3/DRsJr8ayOlIDivFkUfa3WL5Osg2axWwls paUlVX/6H7BUyo8EiSftpxdg1vd/bbrfuT2LCm1oliNHgU3xuZoAgylMKVjo2/0/O61E HUCzw6LpzCSUdEc32/oHx36hiTOuEXcpIBv+v98dnsaPHYKD5cdVITMaxaZy4Ja9/bAx VM/n8eBLdiFvCMgH1WkOf6ZzhXdzSq25wDYbxdicAsBLguYgzyxcB06jgeaHRIoYhlHf Tz32ZjAMF5J3Rge92/MJwg8FXNh/fjBY1HOPBMqlmt1VoQizhpIimJeiuEw0hJYI5hrT Z7bQ== X-Gm-Message-State: APjAAAXUQh57T7zP1CsYKkLXkYr7IkqdJLz4zH4/2wjzJc/vCKVURE3n 6bLspmuxt777+vAcXKjWFv6gl5x/pJjOvl4dteI= X-Google-Smtp-Source: APXvYqynJhSAT+cBLFOG35mXdSu5donpoINx1X4oii7KCRStNIR2N5Cf8Hh5JzERBkyy6grUixES2mbAfr5mZU7d3zM= X-Received: by 2002:a62:168f:: with SMTP id 137mr31383941pfw.151.1574625277865; Sun, 24 Nov 2019 11:54:37 -0800 (PST) MIME-Version: 1.0 References: <1574604530-9024-1-git-send-email-akinobu.mita@gmail.com> <1574604530-9024-4-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1574604530-9024-4-git-send-email-akinobu.mita@gmail.com> From: Andy Shevchenko Date: Sun, 24 Nov 2019 21:54:26 +0200 Message-ID: Subject: Re: [PATCH 3/8] platform/x86: asus-wmi: switch to use helpers To: Akinobu Mita X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191124_115439_695987_090D1008 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Jens Axboe , Amit Kucheria , Jean Delvare , Sagi Grimberg , Linux PM , Sujith Thomas , Daniel Lezcano , Linux Kernel Mailing List , Linux NVMe Mailinglist , Eduardo Valentin , Guenter Roeck , Keith Busch , Darren Hart , Zhang Rui , Christoph Hellwig , Andy Shevchenko Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita wrote: > > The asus-wmi driver doesn't implement the thermal device functionality > directly, so including just for DECI_KELVIN_TO_CELSIUS() > is a bit odd. > > This switches the asus-wmi driver to use deci_kelvin_to_millicelsius() in > . > > Cc: Sujith Thomas > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Daniel Lezcano > Cc: Amit Kucheria > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: Keith Busch > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Sagi Grimberg > Signed-off-by: Akinobu Mita > --- > drivers/platform/x86/asus-wmi.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 821b08e..6a1a2f9 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -33,7 +33,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > @@ -1512,9 +1512,8 @@ static ssize_t asus_hwmon_temp1(struct device *dev, > if (err < 0) > return err; > > - value = DECI_KELVIN_TO_CELSIUS((value & 0xFFFF)) * 1000; > - > - return sprintf(buf, "%d\n", value); > + return sprintf(buf, "%ld\n", > + deci_kelvin_to_millicelsius(value & 0xFFFF)); Leave it in one line. With above, Acked-by: Andy Shevchenko > } > > /* Fan1 */ > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme