From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AA6C43603 for ; Wed, 11 Dec 2019 15:29:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C8122B48 for ; Wed, 11 Dec 2019 15:29:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SEOaGly7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j5C0uyFc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C8122B48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CzjZsmkSVGG9ru9ibW6N8G62prTuZJy5dBYJ0a7hWKU=; b=SEOaGly7fjNsum gSP8IKN9h7IC8uC7ZKrJ9G0U3ac7iObmAcWVRTw1th/9uGG999YZNZtCtkPgnI53nDmLhyJNp2Ecp amGPp+XBkOXqWaF5MIa9dG3R803xXHUJtc4LjvjbMgv2ZbNyLBxUuPtaOrxV4SLkiISqQcH2iDRWV 45pNRZlCu8uMGSx+PtCwSmGT8XXHgrnc1rRHVdild3gAJKoJyluoF0WRHFCTEco+RiEV++KAv1Lnb CoRzeILu5Pl7XmHNvUyCU7S6qUrG7RMcbHp5z2Ff1cZnlWIhMIffqc09AHNuVidEq5COtv9iBCimP 4aDEdD43YbUob+Ze3g9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1if3vb-0005ii-1t; Wed, 11 Dec 2019 15:29:27 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if3vX-0005i2-NE for linux-nvme@lists.infradead.org; Wed, 11 Dec 2019 15:29:24 +0000 Received: by mail-pj1-x1042.google.com with SMTP id w23so9077680pjd.2 for ; Wed, 11 Dec 2019 07:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pfDhDYFuoXDrqHRE8i/08ZQEyfFGj50C9cMmD8Jy2MA=; b=j5C0uyFcwXKjxMT2bhJ14CbB+fZCEQxShkK6p3Cf93qQ6BpSTKh005B5VD2g3OiyqF /wNRFMf+eDpSe4TXNqE6yRjbz6RybfTWfb6JvF2sgW3j1ebFqzHfH+knhZW5LWMcLU9Q PPkMZlifZ3WANqTGfezf8poByuNPftyfj2T8ipV3B9YeSB8ICKW5MsA6kddHfyed3zGU vic5lX9Flai49PViVVxoFnEQJ1pk/ccakyFpoYFqPpU1m9xHZDAyiQ7nU9kNfJZthfG6 7ElzzegodjoKVuaP+P5wut6UEuDXichyFzp4GyPgvDzsqKx4ZybnxVzEt/Nh+yrpsJgq kRqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pfDhDYFuoXDrqHRE8i/08ZQEyfFGj50C9cMmD8Jy2MA=; b=CnuGSHV1Idf0jh+dx7jCjcdvHfIJSG1k8ScYAzoC9dHM93pGq5EvqfETE5hErE2t/U CaS74cmDiTZO7ZlU6nKH815C/9j+NHJ+Q297rIb1i61d7EAmf5ONfETRJYvJLYBjpNUN 3FRdjpz8qLPCQvLtdqq0/BygxdofWtoq54rjSx6gDpHF+ahO0D8/ft3vqi5U85MSvjFd gW1VODwTvCJaf9yGWluGL+7UB+pdtDhodLD+bnTdls0SUh1/StVV+60G6o3Ar/eP0+3/ EWIsWf5siE4vFJ02gD0KC6BuV38RZkHVbdAjcmuoJsDPSgi/fVw52uB+gV8vnSjjNm3/ 60Lg== X-Gm-Message-State: APjAAAXv8LSqnM+/iQjOdctfZRGOL07awwF4nG/IDvHoRjxXY0XdtyxT HQ30ZfzkTuFsewAB0IpIstrQqh0LJt4SogkyAwI= X-Google-Smtp-Source: APXvYqwlR/tF5FA23iHp/eaMoUPuaCaCPBgDqm77FVGRFefN3YELGs3EmpG2NGeQvAJUc/yD31OEVyNePT/dpDkApsU= X-Received: by 2002:a17:90a:b10b:: with SMTP id z11mr4272497pjq.132.1576078162498; Wed, 11 Dec 2019 07:29:22 -0800 (PST) MIME-Version: 1.0 References: <1576075099-3441-1-git-send-email-akinobu.mita@gmail.com> <1576075099-3441-3-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1576075099-3441-3-git-send-email-akinobu.mita@gmail.com> From: Andy Shevchenko Date: Wed, 11 Dec 2019 17:29:12 +0200 Message-ID: Subject: Re: [PATCH v3 02/12] ACPI: thermal: switch to use helpers To: Akinobu Mita X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_072923_756366_75802A9D X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Amit Kucheria , Jean Delvare , Sagi Grimberg , Linux PM , linux-iio , Sujith Thomas , Daniel Lezcano , "open list:TI WILINK WIRELES..." , Linux Kernel Mailing List , Linux NVMe Mailinglist , Jens Axboe , Guenter Roeck , Keith Busch , Darren Hart , Zhang Rui , Christoph Hellwig , Andy Shevchenko Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Dec 11, 2019 at 4:39 PM Akinobu Mita wrote: > > This switches the ACPI thermal zone driver to use celsius_to_deci_kelvin(), > deci_kelvin_to_celsius(), and deci_kelvin_to_millicelsius_with_offset() in > instead of helpers in . > > This is preparation for centralizing the kelvin to/from Celsius conversion > helpers in . > #include > #include > #include > +#include Can we try to keep *some* order, i.e. put this after acpi.h below? > #include > #include > #include > } else if (crt > 0) { > - unsigned long crt_k = CELSIUS_TO_DECI_KELVIN(crt); > + unsigned long crt_k = > + celsius_to_deci_kelvin(crt); It used to be one line, why do two? > pr_info(PREFIX "%s [%s] (%ld C)\n", acpi_device_name(device), > - acpi_device_bid(device), DECI_KELVIN_TO_CELSIUS(tz->temperature)); > + acpi_device_bid(device), > + deci_kelvin_to_celsius(tz->temperature)); Ditto. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme