From: Arnd Bergmann <arnd@arndb.de>
To: "hch@lst.de" <hch@lst.de>
Cc: Arnd Bergmann <arnd@arndb.de>, Sven Peter <sven@svenpeter.dev>,
Keith Busch <kbusch@kernel.org>, "axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Hector Martin <marcan@marcan.st>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Marc Zyngier <maz@kernel.org>, DTML <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org, linux-spdx@vger.kernel.org
Subject: Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver
Date: Wed, 20 Apr 2022 11:53:24 +0200 [thread overview]
Message-ID: <CAK8P3a2-p=eW8jA=HVztFTq7mUMidRKcyFC_7RB5_8O2NmBxpg@mail.gmail.com> (raw)
In-Reply-To: <20220420043437.GA1123@lst.de>
On Wed, Apr 20, 2022 at 6:34 AM hch@lst.de <hch@lst.de> wrote:
> On Tue, Apr 19, 2022 at 11:52:15AM +0200, Arnd Bergmann wrote:
> > > I just checked again and 64-bit accesses seem to work fine.
> > > I'll remove the lo_hi_* calls and this include.
> >
> > If you remove the #include, it is no longer possible to compile-test
> > this on all 32-bit architectures, though that is probably fine as long
> > as the Kconfig file has the right dependencies, like
> >
> > depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
> >
> > I'd prefer to keep the #include here, but I don't mind the dependency
> > if Christoph prefers it that way.
>
> So thre's really two steps here:
>
> 1) stop uing lo_hi_readq diretly which forces 32-bit access even on
> 64-bit platforms
> 2) stop using the io-64-nonatomic headers entirely
>
> I definitively want 1) done if the hardware does not require it.
Yes, of cours.e
> Trying to cater to 32-bit build tests on hardware that has no chance of
> ever being used there by including the header seems a bit silly, but if
> it makes folks happy I can live with it.
As I said, I don't have a strong opinion either, it's either a trivial change
in Kconfig or a trivial header inclusion and I'd pick the header one because
it's more obvious what this is for without adding a comment.
Arnd
prev parent reply other threads:[~2022-04-20 9:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 14:20 [PATCH v2 0/6] Apple M1 (Pro/Max) NVMe driver Sven Peter
2022-04-15 14:20 ` [PATCH v2 1/6] dt-bindings: iommu: Add Apple SART DMA address filter Sven Peter
2022-04-26 0:56 ` Rob Herring
2022-04-15 14:20 ` [PATCH v2 2/6] dt-bindings: nvme: Add Apple ANS NVMe Sven Peter
2022-04-26 0:59 ` Rob Herring
2022-04-15 14:20 ` [PATCH v2 3/6] soc: apple: Always include Makefile Sven Peter
2022-04-15 14:20 ` [PATCH v2 4/6] soc: apple: Add SART driver Sven Peter
2022-04-15 14:20 ` [PATCH v2 5/6] soc: apple: Add RTKit IPC library Sven Peter
2022-04-15 14:20 ` [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver Sven Peter
2022-04-19 5:31 ` Christoph Hellwig
2022-04-19 5:59 ` Hector Martin
2022-04-19 9:47 ` Sven Peter
2022-04-19 9:52 ` Arnd Bergmann
2022-04-20 4:34 ` hch
2022-04-20 9:53 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2-p=eW8jA=HVztFTq7mUMidRKcyFC_7RB5_8O2NmBxpg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=alyssa@rosenzweig.io \
--cc=axboe@fb.com \
--cc=devicetree@vger.kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-spdx@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).