From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Keith Busch <kbusch@kernel.org>
Cc: axboe@fb.com, Ilias Apalodimas <ilias.apalodimas@linaro.org>,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH] nvme: retain split access workaround for capability reads
Date: Thu, 3 Oct 2019 14:05:17 +0200 [thread overview]
Message-ID: <CAKv+Gu_5MWeNVq2NePnTcLcGvYgJS-cZ7BRf11rBt+iLhdW0-w@mail.gmail.com> (raw)
In-Reply-To: <20191003120325.GB34459@C02WT3WMHTD6.fritz.box>
On Thu, 3 Oct 2019 at 14:03, Keith Busch <kbusch@kernel.org> wrote:
>
> On Thu, Oct 03, 2019 at 01:51:03PM +0200, Ard Biesheuvel wrote:
> > On Thu, 3 Oct 2019 at 13:49, Keith Busch <kbusch@kernel.org> wrote:
> > > On Wed, Oct 02, 2019 at 09:36:43AM +0200, Ard Biesheuvel wrote:
> > > > Broken since v5.3, so if this gets fixed one way or the other, please
> > > > add cc: stable.
> > >
> > > Since 5.3?! 'git blame' says the code has been this way since 7fd8930f26be4,
> > > which was from 2015 during the 4.4 development cycle.
> > >
> >
> > That may be true, but the box in question happily boots a v5.2 kernel.
>
> Looks like your observation was introduced with c0f2f45be2976abe.
Indeed. The corrupted read produces a bogus minimum page size, and the
driver gives up.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-03 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 7:36 [RFC PATCH] nvme: retain split access workaround for capability reads Ard Biesheuvel
2019-10-02 22:05 ` Nadolski, Edmund
2019-10-03 11:49 ` Keith Busch
2019-10-03 11:51 ` Ard Biesheuvel
2019-10-03 12:03 ` Keith Busch
2019-10-03 12:05 ` Ard Biesheuvel [this message]
2019-10-04 21:57 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_5MWeNVq2NePnTcLcGvYgJS-cZ7BRf11rBt+iLhdW0-w@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=ilias.apalodimas@linaro.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).