From: irvin cote <irvincoteg@gmail.com>
To: hch@lst.de
Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-pci : redundancies in nvme_alloc_queue and nvme_init_queue
Date: Sat, 20 May 2023 23:47:37 -0300 [thread overview]
Message-ID: <CALL+9ehvM3GxGS9Y-KVyyK+HyO14yRmGZFEPjD6pmEUMX3VNzw@mail.gmail.com> (raw)
In-Reply-To: <20230521024618.103138-1-irvincoteg@gmail.com>
I'm trying to resend the patch but somehow all the new attempts seem
to bind to this thread...
On Sat, 20 May 2023 at 23:46, Irvin Cote <irvincoteg@gmail.com> wrote:
>
> cq_head cq_phase and q_db are getting set in nvme_alloc_queue
> and in nvme_init_queue, make it so that they are only set once in
> nvme_init_queue.
>
> Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
> ---
> drivers/nvme/host/pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 32244582fdb0..49ae26980a0f 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1533,9 +1533,6 @@ static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth)
> nvmeq->dev = dev;
> spin_lock_init(&nvmeq->sq_lock);
> spin_lock_init(&nvmeq->cq_poll_lock);
> - nvmeq->cq_head = 0;
> - nvmeq->cq_phase = 1;
> - nvmeq->q_db = &dev->dbs[qid * 2 * dev->db_stride];
> nvmeq->qid = qid;
> dev->ctrl.queue_count++;
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-05-21 2:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 2:46 [PATCH] nvme-pci : redundancies in nvme_alloc_queue and nvme_init_queue Irvin Cote
2023-05-21 2:47 ` irvin cote [this message]
2023-05-25 15:36 ` Keith Busch
2023-05-25 15:55 ` irvin cote
2023-05-25 18:01 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2023-05-21 2:51 [PATCH] nvme-pci: " Irvin Cote
2023-05-21 2:44 [PATCH] nvme-pci : " Irvin Cote
2023-05-21 0:02 Irvin Cote
2023-05-21 1:48 ` Jens Axboe
2023-05-21 2:36 ` irvin cote
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALL+9ehvM3GxGS9Y-KVyyK+HyO14yRmGZFEPjD6pmEUMX3VNzw@mail.gmail.com \
--to=irvincoteg@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).