linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Charles Machalow <csm10495@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	Jens Axboe <axboe@fb.com>,
	marta.rybczynska@kalray.eu, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.
Date: Thu, 31 Oct 2019 08:39:05 -0700	[thread overview]
Message-ID: <CANSCoS_GtDm2=FR8grhWHwm5-Aqvqb=4u+z=auY4e1y5eS3Q2w@mail.gmail.com> (raw)
In-Reply-To: <20191031135904.GA5180@lst.de>

On Thu, Oct 31, 2019 at 6:59 AM Christoph Hellwig <hch@lst.de> wrote:
> You might like the idea, but it fundamentally is a bad idea.  For example
> you completely break architectures that do not support unaligned loads
> and stores.

Would you also be against the idea of memcpy the u32 array into a u64 then
passing a pointer to that local variable lower?

- Charlie Scott Machalow

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-10-31 15:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31  5:03 [PATCH] nvme: change nvme_passthru_cmd64's result field Charles Machalow
2019-10-31 13:39 ` Christoph Hellwig
     [not found]   ` <CANSCoS8rN6g7u6iG4SRTcXjdj68cbimvX1n1Ex+FBAkhAAivJA@mail.gmail.com>
2019-10-31 13:59     ` Christoph Hellwig
2019-10-31 15:39       ` Charles Machalow [this message]
2019-10-31 13:59   ` Charles Machalow
2019-11-04 14:34   ` Marta Rybczynska
2019-11-04 14:51     ` Charles Machalow
2019-11-04 14:56       ` Marta Rybczynska
2019-11-04 15:01         ` Keith Busch
2019-11-04 15:29           ` Christoph Hellwig
2019-11-04 15:32             ` Keith Busch
2019-11-04 15:01         ` Charles Machalow
2019-11-04 15:16           ` Marta Rybczynska
2019-11-04 15:20             ` Charles Machalow
2019-11-04 15:30               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANSCoS_GtDm2=FR8grhWHwm5-Aqvqb=4u+z=auY4e1y5eS3Q2w@mail.gmail.com' \
    --to=csm10495@gmail.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=marta.rybczynska@kalray.eu \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).