From: Charles Machalow <csm10495@gmail.com>
To: Marta Rybczynska <mrybczyn@kalray.eu>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>, axboe <axboe@fb.com>,
kbusch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.
Date: Mon, 4 Nov 2019 07:01:52 -0800 [thread overview]
Message-ID: <CANSCoS_MX97_JyLkKrZ7YjTS9L+JsZcPsHpoZ-keA8t3W394Dg@mail.gmail.com> (raw)
In-Reply-To: <871357470.90297451.1572879417091.JavaMail.zimbra@kalray.eu>
Yes. The idea is just to change the 64 IOCTL structure so it lines up
with the old ones so that the same struct can be used from userspace.
Right now the first 32 of 64's result doesn't line up with the old
result field.
- Charlie Scott Machalow
On Mon, Nov 4, 2019 at 6:56 AM Marta Rybczynska <mrybczyn@kalray.eu> wrote:
>
>
>
> ----- On 4 Nov, 2019, at 15:51, Charles Machalow csm10495@gmail.com wrote:
>
> > For this one yes, UAPI size changes. Though I believe this IOCTL
> > hasn't been in a released Kernel yet (just RC). Technically it may be
> > changeable as a fix until the next Kernel is released. I do think its
> > a useful enough
> > change to warrant a late fix.
>
> The old one is in UAPI for years. The new one is not yet, right. I'm OK
> to change the new structure. To have compatibility you would have to use
> the new structure (at least its size) in the user space code. This is
> what you'd liek to do?
>
> Marta
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-04 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 5:03 [PATCH] nvme: change nvme_passthru_cmd64's result field Charles Machalow
2019-10-31 13:39 ` Christoph Hellwig
[not found] ` <CANSCoS8rN6g7u6iG4SRTcXjdj68cbimvX1n1Ex+FBAkhAAivJA@mail.gmail.com>
2019-10-31 13:59 ` Christoph Hellwig
2019-10-31 15:39 ` Charles Machalow
2019-10-31 13:59 ` Charles Machalow
2019-11-04 14:34 ` Marta Rybczynska
2019-11-04 14:51 ` Charles Machalow
2019-11-04 14:56 ` Marta Rybczynska
2019-11-04 15:01 ` Keith Busch
2019-11-04 15:29 ` Christoph Hellwig
2019-11-04 15:32 ` Keith Busch
2019-11-04 15:01 ` Charles Machalow [this message]
2019-11-04 15:16 ` Marta Rybczynska
2019-11-04 15:20 ` Charles Machalow
2019-11-04 15:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANSCoS_MX97_JyLkKrZ7YjTS9L+JsZcPsHpoZ-keA8t3W394Dg@mail.gmail.com \
--to=csm10495@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mrybczyn@kalray.eu \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).