Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
From: Jeffrey Lien <Jeff.Lien@wdc.com>
To: Keith Busch <kbusch@kernel.org>,
	linux-nvme <linux-nvme@lists.infradead.org>
Subject: Issue With NVME CLI list Command
Date: Thu, 10 Oct 2019 19:11:10 +0000
Message-ID: <CY4PR04MB117531DFE8560BD3A72787CFEA940@CY4PR04MB1175.namprd04.prod.outlook.com> (raw)

Keith, 
I'm getting a "Failed to scan namespaces" error message back from the "nvme list" command after updating my fork and picking up your changes from Aug 28th.  The cause of the failure is the following check in the function verify_legacy_ns (in nvme-topology.c):

	if (memcmp(id.mn, c->id.mn, sizeof(id.mn)) ||
	    memcmp(id.sn, c->id.mn, sizeof(id.sn)))
		return -ENODEV;

The problem I see is that ctrl info is never filled in (at least in my case).  Both c->id.mn and c->id.sn are blank.  Looking back in the legacy_list function, I don't see how the ctrl info is ever filled in.  Maybe it's just something strange in my case; I would have thought someone would have stumbled across already but maybe not.  If I remove the above check; everything seems to work so I think the code is basically working as expected.    Could you review the changes and either confirm what I'm seeing or let me know if I'm missing something.  

Thanks
  

Jeff Lien
Linux Device Driver Development
Device Host Apps and Drivers
jeff.lien@wdc.com
o: 507-322-2416 (ext. 23-2416)
m: 507-273-9124







_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

             reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 19:11 Jeffrey Lien [this message]
2019-10-10 19:23 ` Keith Busch
2019-10-10 19:39   ` Keith Busch
2019-10-10 20:10     ` Jeffrey Lien
2019-10-10 19:42   ` Jeffrey Lien

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR04MB117531DFE8560BD3A72787CFEA940@CY4PR04MB1175.namprd04.prod.outlook.com \
    --to=jeff.lien@wdc.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org linux-nvme@archiver.kernel.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/ public-inbox