Linux-NVME Archive on
 help / color / Atom feed
From: Jeffrey Lien <>
To: Keith Busch <>
Cc: linux-nvme <>
Subject: RE: Issue With NVME CLI list Command
Date: Thu, 10 Oct 2019 20:10:09 +0000
Message-ID: <> (raw)
In-Reply-To: <>

Thanks for the quick fix Keith.  

Jeff Lien

-----Original Message-----
From: Keith Busch <> 
Sent: Thursday, October 10, 2019 2:39 PM
To: Jeffrey Lien <>
Cc: linux-nvme <>
Subject: Re: Issue With NVME CLI list Command

CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe.

On Fri, Oct 11, 2019 at 04:23:18AM +0900, Keith Busch wrote:
> On Thu, Oct 10, 2019 at 07:11:10PM +0000, Jeffrey Lien wrote:
> > Keith,
> > I'm getting a "Failed to scan namespaces" error message back from 
> > the "nvme list" command after updating my fork and picking up your 
> > changes from Aug 28th.  The cause of the failure is the following 
> > check in the function verify_legacy_ns (in nvme-topology.c):
> >
> >     if (memcmp(, c->, sizeof( ||
> >         memcmp(, c->, sizeof(
> >             return -ENODEV;
> >
> > The problem I see is that ctrl info is never filled in (at least in 
> > my case).  Both c-> and c-> are blank.  Looking back in 
> > the legacy_list function, I don't see how the ctrl info is ever filled in.
> > Maybe it's just something strange in my case; I would have thought 
> > someone would have stumbled across already but maybe not.  If I 
> > remove the above check; everything seems to work so I think the code is
> > basically working as expected.    Could you review the changes and
> > either confirm what I'm seeing or let me know if I'm missing 
> > something.
> Hi Jeff,
> What kernel version are you using?

Oops, nevermind, there was a couple bugs in that path. The controller needed to be initialized before scanning the namespaces, and then we need to compare the correct fields. Fixed now:

Thanks for the notice.

Linux-nvme mailing list

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 19:11 Jeffrey Lien
2019-10-10 19:23 ` Keith Busch
2019-10-10 19:39   ` Keith Busch
2019-10-10 20:10     ` Jeffrey Lien [this message]
2019-10-10 19:42   ` Jeffrey Lien

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on

Archives are clonable:
	git clone --mirror linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ \
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox