From: Aleksandr Miloserdov <a.miloserdov@yadro.com>
To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux@yadro.com" <linux@yadro.com>,
Konstantin Shelekhin <k.shelekhin@yadro.com>,
Dmitriy Bogdanov <d.bogdanov@yadro.com>
Subject: Re: [PATCH 2/3] nvmet: expose IEEE OUI to configfs
Date: Thu, 27 Oct 2022 12:48:38 +0000 [thread overview]
Message-ID: <D38AF3DC-3F8A-4EE1-8252-71A7F0971823@yadro.com> (raw)
In-Reply-To: <6f630727-72bc-6ae8-e23f-dece692c31e7@grimberg.me>
> On 26.10.2022, 14:49, "Sagi Grimberg" <sagi@grimberg.me> wrote:
> On 10/26/22 11:31, Aleksandr Miloserdov wrote:
> > Allow user to set OUI for the controller vendor.
> >
> > Reviewed-by: Konstantin Shelekhin <k.shelekhin@yadro.com>
> > Reviewed-by: Dmitriy Bogdanov <d.bogdanov@yadro.com>
> > Signed-off-by: Aleksandr Miloserdov <a.miloserdov@yadro.com>
> > ---
> > drivers/nvme/target/admin-cmd.c | 9 +++---
> > drivers/nvme/target/configfs.c | 49 +++++++++++++++++++++++++++++++++
> > drivers/nvme/target/core.c | 2 ++
> > drivers/nvme/target/nvmet.h | 1 +
> > 4 files changed, 56 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
> > index c8a061ce3ee5..0b415335bb5f 100644
> > --- a/drivers/nvme/target/admin-cmd.c
> > +++ b/drivers/nvme/target/admin-cmd.c
> > @@ -372,6 +372,10 @@ static void nvmet_execute_identify_ctrl(struct nvmet_req *req)
> > memcpy_and_pad(id->fr, sizeof(id->fr),
> > UTS_RELEASE, strlen(UTS_RELEASE), ' ');
> >
> > + id->ieee[0] = (subsys->ieee_oui) & 0xff;
> > + id->ieee[1] = (subsys->ieee_oui >> 8) & 0xff;
> > + id->ieee[2] = (subsys->ieee_oui >> 16) & 0xff;
> > +
>
> put_unaligned_24 ?
Seems like a good idea, I'll add it in the second version of the patch.
Did you happen to check out the third patch from the series?
next prev parent reply other threads:[~2022-10-27 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 8:31 [PATCH 0/3] Allow user to set nvmet firmware revision and IEEE OUI Aleksandr Miloserdov
2022-10-26 8:31 ` [PATCH 1/3] nvmet: fix memory leak in configfs Aleksandr Miloserdov
2022-10-26 10:49 ` Sagi Grimberg
2022-11-01 7:52 ` Christoph Hellwig
2022-10-26 8:31 ` [PATCH 2/3] nvmet: expose IEEE OUI to configfs Aleksandr Miloserdov
2022-10-26 10:49 ` Sagi Grimberg
2022-10-27 12:48 ` Aleksandr Miloserdov [this message]
2022-10-28 11:33 ` Konstantin Shelekhin
2022-10-30 8:29 ` Christoph Hellwig
2022-10-26 8:31 ` [PATCH 3/3] nvmet: expose firmware revision " Aleksandr Miloserdov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D38AF3DC-3F8A-4EE1-8252-71A7F0971823@yadro.com \
--to=a.miloserdov@yadro.com \
--cc=d.bogdanov@yadro.com \
--cc=hch@lst.de \
--cc=k.shelekhin@yadro.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@yadro.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).