From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C279C4338F for ; Wed, 25 Aug 2021 04:59:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D226A6128A for ; Wed, 25 Aug 2021 04:59:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D226A6128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/sBHY/0yi3c7VoWSklnXTJV50MAiIAikR6AJw3q4ULY=; b=Dt1L3QkT8pK/wi X22a+ci+ByeLOZrAn9RcB6xoJKwySYnXGSlVsIzwVteah+806o3jLutOc6i61SV9ZCEghSuaE+3sg Sx7xLz6+CilDDXZULW6u/5f/G07mCCGKEu0JVMVpGOD+nju+sPtR5NLUx3dbFZVsJ5ePoF81393ep jOAlRLRgK3gOGaEt0YFK3fDZGVr/9ehO99pT/BFyU949+ZF5DRnPB42GX2eQQ8ziZn9nU52nLmGcf INTtY/wklfv6iWdZSgdKhH1Vat4EYCEyTmbFKJXpJEpar2V/qLjJbkFzYdNHQvWsRZ3+XkETIiHnu IBd6jTrX807V8Id+zElQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIkzx-005VTq-1v; Wed, 25 Aug 2021 04:58:49 +0000 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174] helo=mx0b-0016f401.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIkzr-005VSu-2B for linux-nvme@lists.infradead.org; Wed, 25 Aug 2021 04:58:46 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17OIU6pR023381; Tue, 24 Aug 2021 21:58:33 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-0016f401.pphosted.com with ESMTP id 3an63u1wmb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Aug 2021 21:58:33 -0700 Received: from m0045849.ppops.net (m0045849.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 17P4wW6R022344; Tue, 24 Aug 2021 21:58:32 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by mx0a-0016f401.pphosted.com with ESMTP id 3an63u1wm9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Aug 2021 21:58:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qmd2fWUvp66DJ/o8vRXpyoNiY8a8lGiLQcwcd2fi+QAzuQU5WxrvhfLhT6b1nemzG86D5+ffmJt+iQPDiBoSobFGRXADdBuAndWTu9A7UVOVCaXhkJqnJcYLTfKJod6XsnihMIZdYWPQjJAsIEF3WzGCgbbBDoBqVA54Op78O/VBpCZ4OqKZF9fZe0CF7Y934wkgXJKTn6O08fZH5lMCqDs3VtVDm4BHc8+kKf0ctRe9NnMBGoBZUgFfsPeqeRdlQEi2NV6KqJT6syvKkFZThGzFgoZ2GLHFaxvPtkmAPVlDvhHBBOD1jN/Vxs1JraEfsEBzJBa8XAdUci44LreSMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=79eFEBpLTouJoMrN421A61/aiJjhvrq9hBDQX0f4nik=; b=D0a3A8cOESc1Ffe81ezWeHFpjepmVDB5q60rgqvWdFk9VejboSA8sLCeUcdWnHrVB6GkDqLBWkQ0r5boTrbIQN6IXgLGJNbA31WAo2tGxt+5D744i8nwfZwj+4aU8heR4DsKT30N9+5LsKyH9+xhP03Vl4g3tVcINALG/oe9t2u2k7sV49EiOeu8KrtsyY+Rb2xJf3qbT5vuHdezyfUKVy7kKYsmHWx3UO+/6Rm8R077/MnLa+//fsyx+HIn2E6kS3mMH3vd529ipRx022MQpcZ8lpz8UGaBT6ryR5TseBAo3ypMKwQyFbj9u1RUmKMqvPh3JtIP7JftSjwd30HPdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=79eFEBpLTouJoMrN421A61/aiJjhvrq9hBDQX0f4nik=; b=F65CtLkSb5Bmr4RT2w0V/S7lYT4nSDjyNTHrrPaHHRIirxUxdx6PuHXBPtNGsmyZywy9uHSmuuQJtGqn3b47KGEx45vcXSn8KThSZe59zDOzCmhvR92DXkXuQ/sw428wyGMm6H6MB7/+L6lOG6icyfrSM6j50nsAy1x9Ga0fgp4= Received: from DM6PR18MB3034.namprd18.prod.outlook.com (2603:10b6:5:18c::32) by DM5PR18MB0921.namprd18.prod.outlook.com (2603:10b6:3:33::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Wed, 25 Aug 2021 04:58:30 +0000 Received: from DM6PR18MB3034.namprd18.prod.outlook.com ([fe80::51c2:62c:df04:89db]) by DM6PR18MB3034.namprd18.prod.outlook.com ([fe80::51c2:62c:df04:89db%4]) with mapi id 15.20.4436.024; Wed, 25 Aug 2021 04:58:30 +0000 From: Saurav Kashyap To: Ming Lei CC: Sagi Grimberg , Nilesh Javali , "martin.petersen@oracle.com" , "linux-nvme@lists.infradead.org" , "linux-scsi@vger.kernel.org" , GR-QLogic-Storage-Upstream Subject: RE: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support Thread-Topic: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support Thread-Index: AQHXmB5nQhsPGOkOI0qGifl5VUdIxquBVlsAgACqKsCAAAR/AIABpizw Date: Wed, 25 Aug 2021 04:58:30 +0000 Message-ID: References: <20210823125649.16061-1-njavali@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c4c8ee0-2659-4262-c182-08d96784fba1 x-ms-traffictypediagnostic: DM5PR18MB0921: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b+kP54bchDF/RFIUGjMnf/P3Ez0nw0zu9Ys7J6dvMM508zA6xMHK4QwqsV1z5Y+kuDUuGlQAYEoh+GyP9SzDzrgkdeWPppBJWnJIlCW9MxrcjLkpDoglFCEB/r7UPD26yn2TLGR9whuXcfimg2/MP/gNBf/t+WiJhfDFqOjgsSV23YfyU8MyY8TbkXTQ3sQ1xyxNyiV0gAx8e23dNKPsH94fKC/mOfxROvTj2kIQ3KMrdjHbkbHZRn6eSZ5ePWdoFZjPl7kEzGt5wh9ccZbqckJYjaBnsQvcvCr4v2aii5zfWeWFLleg/sVI5fk58EzcHdbbFPniFHVhyevXvBnW3Hcmix9J1AjVup3x7mj0BCHLfoFzq9G5vYv2JabbbmbWyo580VBKUYyBagKNMHH0GoWojeEfkO1giag5HuBFi0oVLJhge9IOEgteD0kxRYd1gepnuJT9wAyYhKCHXCYtlpS7TDvS+2kvzf5YTDA7cLyvd02boOscbkalPuMSN2HwHxNYIR6FkWUtClJGfyCa0IXxeIY9+qxrHjvh2XhBWd9u4OQiND2FhTb5A45SVAh355GwmdFhetlgYEAckEXQHJ45R497VtH/5HJrcFuh+FLqT67aa2iC2TYlr/YQXQg8z/4ZdexV31MkyXoeAP6L3wUOMthJruSnlaTLYjMa+2+hqhwkGXFcgOSabvO1kP5bTeTCTixpyzby3/fK/gnQivf/rXd7UH6dxkGxlWs/ygi5HGmObAnCI09aOep9YZYAohqG/5djxVxvdFUi/yPeeMTivLyKLOoVEcnKkQQLP+o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR18MB3034.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39850400004)(346002)(396003)(136003)(107886003)(6916009)(8676002)(7696005)(19627235002)(966005)(2906002)(55016002)(38100700002)(122000001)(9686003)(83380400001)(86362001)(52536014)(71200400001)(54906003)(38070700005)(316002)(8936002)(186003)(66446008)(478600001)(64756008)(66556008)(66476007)(5660300002)(66946007)(33656002)(6506007)(4326008)(76116006)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6lI/yGxmCmyWi9MBQQHZb8tkxnigvobQnw+e5PxMt08vR+B1AgtAxlCNj/Rm?= =?us-ascii?Q?JrWKBSnL9frHV5UXMOaTHDJAaJDU9Yy7wHJ7sk5kPzJKbeFqy8gfagDftulq?= =?us-ascii?Q?dECI5SJRKdlr4ZFgPjEuICnDNQZ5g97IG4AkNIons/ggL+LIRH+DeKd/787U?= =?us-ascii?Q?bFtO/cSkiM1b1Z13OM3e7Hk5DkXNPkHsNCH0r5E+lgueScRNGYkVD+1H4K+j?= =?us-ascii?Q?Ce9X6V4JfK3XZuDnEQUQk/KzEFSw5XA9JaSrMSSkWYpE8aTYyW+MU8fXJsfX?= =?us-ascii?Q?geaSq730BexBQ3+wVS+/cSNwSAymvCYD24w6ZJTcLhb/HFhF4jcluyzkmADx?= =?us-ascii?Q?eqETAG/UWBHJFAGrpyi/OT/tMGTQLBn3QqozRht+tbw0rsXdkBpA7ZwQNest?= =?us-ascii?Q?huho4BT5XvMY5H+RUM8DcE7Zls7JDXtQDBgAxFzZ+yZQsRp3k7HKcuNvp927?= =?us-ascii?Q?1stiXYpKgT/W4E2aw1Wny36UySixhr8JQNfJoNcFYocJ9oC9Ht2pEAQ/4Kv8?= =?us-ascii?Q?fcIE2wzbYL/t2aaTF6u1izaX+mipa2/1hSKbjGI7oxQzv2Ykp7L0BGM06usC?= =?us-ascii?Q?drFJLk+Gm3pXt38FfxH2Ps23vAhSQkq4OTI8I1phdGz2SD0atScfYw2dgs8l?= =?us-ascii?Q?9gCSyudySdb+RUzYYe44i9FcTbC0sTBMQlVu6in42VJIwL/yAse8ebByd80z?= =?us-ascii?Q?kAs9YjjGwftq14Y324cK+XtNPCGytN3pGJVgTgPP6KdzbO8jTuiiBqKsNVpW?= =?us-ascii?Q?pzoEabinLx+YEZkdaZH2g79gQNigOIWklMaces+jIUpa7fG3/3Ka1ALmXF19?= =?us-ascii?Q?YeoQw70D6cLJNkb44KbFiL0sn3kyT9/57MwE6IQKnojTbhdEj5SnQGOPASHz?= =?us-ascii?Q?HDbtves4uWbYpeaQOvJUrqKkhDeoi+PiFLcuGTq2ym4wv7LK4TusgGnTA5Ad?= =?us-ascii?Q?nf4yRJZTBm/j42LGUmwapvQwGNcXZ28xZk98Ku/amwUb2hK5pDKzvoEAvHQw?= =?us-ascii?Q?SEN5Ks/2uyhS6vvY/sIdue0F6zRvnO2XryaRHgZK5ohCq/0sAw270c43Kr0Q?= =?us-ascii?Q?Ab7R0MpSF2oYZYeA5ewwYncIrNNk8Q8VksCBz7qvCUlV7/v1uAxYOzL5BcZI?= =?us-ascii?Q?N5bB0yqi9pZ6fdfnKH4jGZhvW4aeToK3wvZ01kjeXAHIIUZUgkO0EdJSNNi6?= =?us-ascii?Q?xgbFErKWdKXXFnlRJy8k+iT35gY/HhqjR2KaZuE54Kw1LWft1OPR8webMS7l?= =?us-ascii?Q?8xfEtVtKlU/FOCzW+/JnnIAwGDlOZATJUjQrbotaa2MiDXsBeShmcG1Owxl5?= =?us-ascii?Q?wOthWo92Bvyvpn4XMQwiNZhj5UxlNvZR1qhhjKjPmMc9RoFbkGr9OEHKmQ21?= =?us-ascii?Q?ta4kTq4CJiZWUOBnZyO/ArNTw330?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3034.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4c8ee0-2659-4262-c182-08d96784fba1 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2021 04:58:30.3392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jZnwnp4hOVVZgo4TrCjkOajM2qHXwwXh6ilokBocby3gUnT+29YalxANmKWbxmbDgQI6XwXNX3oSv7Oua/VWbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB0921 X-Proofpoint-ORIG-GUID: 3Eywz9FzWWTyBujoY7LvFmmGkwvXqX6G X-Proofpoint-GUID: DqGp5PoBaoe1UPZc8Y2uh6xMbRrn4c0J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-08-25_01,2021-08-25_01,2020-04-07_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_215843_234611_5DE8CA40 X-CRM114-Status: GOOD ( 24.43 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Ming, Comments inline > -----Original Message----- > From: Ming Lei > Sent: Tuesday, August 24, 2021 9:17 AM > To: Saurav Kashyap > Cc: Sagi Grimberg ; Nilesh Javali ; > martin.petersen@oracle.com; linux-nvme@lists.infradead.org; linux- > scsi@vger.kernel.org; GR-QLogic-Storage-Upstream Upstream@marvell.com> > Subject: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > External Email > > ---------------------------------------------------------------------- > On Tue, Aug 24, 2021 at 03:38:24AM +0000, Saurav Kashyap wrote: > > Hi Sagi, > > Comments inline > > > > > -----Original Message----- > > > From: Sagi Grimberg > > > Sent: Monday, August 23, 2021 10:51 PM > > > To: Nilesh Javali ; martin.petersen@oracle.com; > linux- > > > nvme@lists.infradead.org; Ming Lei > > > Cc: linux-scsi@vger.kernel.org; GR-QLogic-Storage-Upstream > > Storage-Upstream@marvell.com> > > > Subject: Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > > > > > > > > On 8/23/21 5:56 AM, Nilesh Javali wrote: > > > > Currently nvme fc doesn't support map queue functionality. This patch > > > > set adds map_queue functionality to nvme_fc_mq_ops and > > > > nvme_fc_port_template, providing an option to LLDs to map queues > > > > similar to SCSI. For qla2xxx, minimum 10% improvement is noticed > > > > with this change as it helps in reducing cpu thrashing. > > > > > > Does this make nvme-fc use managed irq? > > > > qla2xxx driver uses pci_alloc_irq_vectors_affinity to have affinity with each > MSI-X vector. Currently nvme queue are not mapped based on affinity and irq > offset. The change is to use blk_mq_pci_map_queues for mapping, this function > consider irq affinity as well as irq offset. > > > > OK, got it. Even though without this patchset, nvme-fc actually relies > on managed irq since qla2xxx driver uses pci_alloc_irq_vectors_affinity. > > Now the patchset[1] isn't good for addressing the issue in > blk_mq_alloc_request_hctx(). Can you please elaborate on this? Is there something needs to be done from my side? Thanks, ~Saurav > > [1] https://urldefense.proofpoint.com/v2/url?u=https- > 3A__lore.kernel.org_linux-2Dblock_YR7demOSG6MKFVAF-40T590_T_- > 23t&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=ZHZbmY_LbM3DUZK_BDO1 > OITP3ot_Vkb_5w- > gas5TBMQ&m=CqFDnfAsZphubKXkUx5gsRF6RZ2Qe6sxWkYq4pBfFD0&s=2Nba > EUI5eB6_R6PxW8ld1Xn2OU3_UdD6D30uvFAWhow&e= > > > Thanks, > Ming _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme