From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E2AC433B4 for ; Fri, 16 Apr 2021 09:26:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D72A76113B for ; Fri, 16 Apr 2021 09:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D72A76113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date:Subject:CC: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=Hk7zZeTL5LXGpspGVl7rjfBDnIUDFNpKTyrmITRKoNE=; b=Als2bA9sOkvUWGYuPuBd9bd8I ZXTjomLwxUzdCi7caqBaN0b2XA88b0SeUcMqKnU5+mSVkfTql+eGbBYJ9Gtu5O+PHdVpAhSIxu+UZ k2slwD3u6D+izjDKnQ4mzpTNXZQZd4Zw9zmZUS4OyzvfT7uiL/naEUBhZQkSBHCou+qDm1DyhZOo5 QcbhHx0dqeodfesQxQjmHa6+iRE9w4oFut6RiIqsAqlCvtlImwIuTmIpg9t/Sg885kHRerRfPz3ag WhBoCxzwqYQIWrMVG7OCzVguFAAItmy1vD7yxhZNzx8dXV+X52fakzJ6N9sQeB4Jl0FZE5tlTtiEY zYztfzlCg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXKkL-001Xnu-Hd; Fri, 16 Apr 2021 09:26:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXKUX-001Ue0-Nh for linux-nvme@desiato.infradead.org; Fri, 16 Apr 2021 09:10:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:References:Message-ID:Date:Subject:CC: To:From:Sender:Reply-To:Content-ID:Content-Description:In-Reply-To; bh=yBa8yhgGTC7hLUhn5Z/9azcVk4gzxkO6VyTIIZjkvGY=; b=t95WKi6xLCK/glpMzWkNrzUFyG JQjtrSt2nYkQ5wUDBbQW2zFYYMIIaVBtxRWsIqwSCzYsORjmRlp2sBliQJgTCwqk+uOAu1SBQkQi3 wCCfJz1SFZker4U+NSJudfRrdSZ7JNRAw6H0PW9LhVnis1n8mIcO61zA3UGuYJAi02ZVm0dekxNU6 eNfpIIWQpn9S3jcU4YmU26ADZp8hjVn+h/h1d7g+EM94Q0aHfKStSgjSyRkoTEVWKaOUCzc2vYVIS NoQHb+vjuxL3hMpCUb9Ex3gJGTOyn/iG/WKeEZrEFYNKWNgRDozl3vurE0NDV1AgUywKryYdZU+Os DJZeWBbw==; Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXKUU-009EKs-MH for linux-nvme@lists.infradead.org; Fri, 16 Apr 2021 09:10:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618564218; x=1650100218; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=imTaOkCZPRbnsmQV2H4ATRDLT44Z4fPiF2DvrP0Txno=; b=gaYzkYZFigcaH2LdHmtkb6MMD5GC+OC9nxgDSGehSWVdiFb3EFTbP989 VseKLBg6CXpZP1bnJruX4OeozuypHjWh7C44uGm7qWqT15l5kYhdpw8x7 fNj/ENpQCU7MKaBIcvn3EI12toQKugNuozrDVT8xc0LKu0e/q1cgzjU/z x6Ww8Zppnviubwt8cUCjEqRlqAqrIs2Kkc6k6eQwwQrEL6XPn6x0l4Gmp dcqbZYvB+0nRyHMW5FgN+FYoaIJ84ds/xPAzU8qLNJzUHd81CvPprWC46 SzaQ858pWqRhqBTFykj4aNHtzWqFR54H91nEVJmzetLOWVXkMcKqHVoQ8 Q==; IronPort-SDR: MiLZfWoRNKg8KEuWG+klkIgLCDI9CP4wEIvuTEEDTXz9mO29wOqR7LDnfGeSM/rVkys9ZdOGS7 kDFTaPDVyEnuOe0uKwFSnN0HoFvwrH/aNsugTAdoFa8mH014+jP8E30PpnXhh04QtNCCe5u8Td AjwT9iOW8QxQGA5iGeB66fI7ZccyjE0unyVMrwv9oTp7M/Ge1Fkv2+MRnIyCrMWmp8n+/MUEvH pbtsIklrx1A0ltVjwj4++Ux4ETpCAmXK3/09drbI+9qgP/JU+aCsSUWABFc3UbiUIaOnInx1KZ x64= X-IronPort-AV: E=Sophos;i="5.82,226,1613404800"; d="scan'208";a="165068791" Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hgst.iphmx.com with ESMTP; 16 Apr 2021 17:10:14 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nBG+CryC4F1LadXRuOKCX8WF4l7ba5BfHzTXkqf0UhbC6RylUanqwBd6ck9hJt+kKUnIBpTXqhnK/9w6OYEy375j96C76Eql0MPH/7AYPDbH0cv4UwNYMo8Ko4kT4n8ZyzJjt0Zjj5KYmFMFxII0VyisHxCG12O8yg0+DFQ0jxL6OraWsI3J1V5sUHKfPS3jnfC26SftrMZP/i0VzU4IYN/HMEvPMFbMM+NcTOfYEghTBeXubsQPbQTEKvsh02Z2loMkqqGy75837z8uEdvF60/QCf7Zmvv/yv/4OEZbGmCdnrEu4Lkj58DeQ25OHJx47llVkU/kjyjifTVeICJTuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yBa8yhgGTC7hLUhn5Z/9azcVk4gzxkO6VyTIIZjkvGY=; b=OUuJpA+L+bbdvQw1rul65E5118ArTlR4esEibCHD45RCY0YRz1TARMk7GRU1Wld/F/9tU+uUyWK3uQxxYNXnFTdfdKBluk7FLDc+PkcQjY46PZPb8slk7Jvg2+fOZnP0KAsO5sta4Otfk4bUJ+LsZgA3LcFD0G7xkHO0qyL1WCrEove2LTqsXS7r326MSaywx834NoYfBDziO/bSLJ8H3JBh+Ir/xDOWVJARMUv7xZfYi+dnGNX8V1q1jUWqv89DOx444Q6nptlaUsPFCTKTIk+4yzY+9NoP7pWdLonnJ4mFZyMQ5mEel0JBty6PgeUEB1EH2MHWmNqpYTPw1XtU9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yBa8yhgGTC7hLUhn5Z/9azcVk4gzxkO6VyTIIZjkvGY=; b=vkLJtdD/UFPIV+9SbNn6iYHPMiNAR181GgITSpTftD+V91k6kfjgipwE1QMW6z1TVPfu9QQBDMfhY1ri7q5q7Epu6knD6mZL+WTrVNP84K5atGOpR0LzsuWBIPdPWjmDGw5uDJXRWMIEot0c5SLl1dFom+1w2vy0KnaMq8kEBqg= Received: from PH0PR04MB7416.namprd04.prod.outlook.com (2603:10b6:510:12::17) by PH0PR04MB7383.namprd04.prod.outlook.com (2603:10b6:510:13::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Fri, 16 Apr 2021 09:10:12 +0000 Received: from PH0PR04MB7416.namprd04.prod.outlook.com ([fe80::99a5:9eaa:4863:3ef3]) by PH0PR04MB7416.namprd04.prod.outlook.com ([fe80::99a5:9eaa:4863:3ef3%4]) with mapi id 15.20.4042.018; Fri, 16 Apr 2021 09:10:12 +0000 From: Johannes Thumshirn To: Damien Le Moal , "dm-devel@redhat.com" , Mike Snitzer , "linux-block@vger.kernel.org" , Jens Axboe , "linux-nvme@lists.infradead.org" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "linux-fsdevel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , David Sterba , Josef Bacik CC: Shinichiro Kawasaki , Naohiro Aota Subject: Re: [PATCH 2/4] dm crypt: Fix zoned block device support Thread-Topic: [PATCH 2/4] dm crypt: Fix zoned block device support Thread-Index: AQHXMm1huarhzLzpkk6eySNmcPNHIA== Date: Fri, 16 Apr 2021 09:10:12 +0000 Message-ID: References: <20210416030528.757513-1-damien.lemoal@wdc.com> <20210416030528.757513-3-damien.lemoal@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [2001:a62:15ab:1:e10b:72a5:d443:5e5c] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4ad6c94-3f01-45bb-a9b0-08d900b77107 x-ms-traffictypediagnostic: PH0PR04MB7383: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4xeyFLY6B13CHdzzBRHxZkc6JQJOEEY4M/Jxs319Bw9Wb+I7PG0Gq6+8Z6fUuWdbqdkABcLc2T9NqtM85KtzOcau4WLRp6urzABncuhRG2UV4TfZTlYJsEqxSqFweJHFS84Re24yhT2spCzWbb2EjTBaDQE2k/QaBdD3yK4rQMj3NjunMq69QcbEIFyNxzO6/IMy7ZbQBZS0xIzJoYP4sKVRlshYpYEV+OnxDAECgP0n6e/fEhb80PMcXFh42KkBQzedKfaI7yoIBzSfVrLr9se+HMRo8YLE2Qf21tq+gxWDu+iYSC0xTcglVzzc36IDm0l3n99SajIenTfBvfLQ5hv9JOnn3P0kLrpIoAluhrXVf3E/Wgli1dubp1+RY9MO0MCFwN/NKKO/RVEuE5OW762hj1Foab54CVBETq+U94N2W1rwJggissfE5FsrHZ0UqeWB+vNpQaoQCCpWuE/R+N3Kd/bFbrOnUoo66mJdBV8NsvpQ8CXcGSK6UHD54g7vTQuxwhJxilDZ2GFQZRkS22RsyB7sNXBuYrerN5rWN5g7UkinWrYVYdBG2jver3XP92jfDejA+XzcpBzsRxdADmIN9zx+fv/Y0Y/3DtEOS4b94zwdRPyVrefJxgFfoJ1Ukq9z7hkBi5sBupmb05fpZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR04MB7416.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(376002)(39860400002)(136003)(52536014)(38100700002)(2906002)(9686003)(71200400001)(54906003)(55016002)(64756008)(122000001)(66556008)(76116006)(91956017)(110136005)(66946007)(478600001)(66446008)(8676002)(66476007)(53546011)(5660300002)(7416002)(33656002)(6506007)(7696005)(186003)(921005)(8936002)(86362001)(4326008)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ty19zkY6Jdr5NtQbX+ggf7h9/50G1UwFhltIcvwk9VggmMw68QQy6ON7GJuh?= =?us-ascii?Q?WQKb2wCJAA4QkZ1nhgv+3OLTUisS3WLGdTUSKhftThezH1rqwnSZlUHbBKM0?= =?us-ascii?Q?RkYqp1fqomGYC22prcLjRi/oILczQk5XarxBw7fs99zJSHvhMwLEC54eUv7l?= =?us-ascii?Q?5mOu5k0Tzy/mJg0C/4h6nWjA3t7jrD0fYBet1nNZScAQgkPV22o8ibAzHxx0?= =?us-ascii?Q?65E9JVY3iFL78wDZhNNUEjWeYs0jI4+euR/vyvXrSFrtXbOMcCSTYD1TbK4e?= =?us-ascii?Q?sWqUOwnxnvYvpFWaICL6c2rOiGZqvuP53ipzLrXnCZD9kU6rl8/az90QLHkI?= =?us-ascii?Q?5oroliQqPMBQ0V9UluqJr1sOJGU2g3nzmEZM0C7l2okZFmAV/g0EJQVKS4Ee?= =?us-ascii?Q?/bcuIrie2DYR8XD6MtQ9+N3+y1cJn/knDDhXXo+rbqfdKwZdTDNE7cor5reB?= =?us-ascii?Q?jaxB8p+3BUiBHtb7uXqp5UOY9R7mob8iZneDNlqvnzU13j1/CZqhBkEpuWFU?= =?us-ascii?Q?ZFsfpv88u4n3kFP22RfP3OOaZv2NKNphzf7F9dq+8zP4QpbJ7dCH6WN9datA?= =?us-ascii?Q?kF/Qt2txqb7wlk0OEkNFMSvztXcZG1ZWtmVQSYZOmqstqA80GEuEF6NouPOA?= =?us-ascii?Q?Kbdof/CHnuagCnCr3pOY1DpIuI3FlkeECPSLhK8iNCYi9ecKd3Ke9fNrOC0a?= =?us-ascii?Q?+2JStHSrAdMgT3fPS+QYo+U5eO8yCtfHReU6JyO2b0i1MuY5yvMmZD0eUZzN?= =?us-ascii?Q?4tvQNjrF8KpOn3eiThBKQxSgVDbW4uWsQNWA8g32/UUWxi4N8gf3UbAmRqds?= =?us-ascii?Q?4CrGSxjTEAtlrx8HFW7SkXrKB1Sw/r6wBl5Szs2YJ3SX91SbvoEeV+b6N6bU?= =?us-ascii?Q?urTVd7TWWdocODAbIrj7bOWABZTzr2qXRfULvHxFTwfHQan4RmWdLnDVB7dt?= =?us-ascii?Q?m+SUJn3UBjoaTMbXDHhTCAIKl9Dv5DAVA34EkoD5zW+lOdtEDvWTLUjL7rKL?= =?us-ascii?Q?lsjzMPqHwi6dXwYnQv36scsvfNye7+H/hq4jWsoOXXdHU0EOlDnnsOQoXhMB?= =?us-ascii?Q?xJkTVO29CBFE0KnlBU9+kkjEocxOlXZvgeyAW3ka+4Ny3Y3ndSxmsjNa70y+?= =?us-ascii?Q?pStKzsF31H6Z2U/BDEvLAh9Ixa3knMz/iEAV4yHy+M1Ha01qVTLaW1iIHfih?= =?us-ascii?Q?dHHFeBiVNEPCakRluwWtwwIruYwLgZEmoXyKBXBkxVFbQvBH/51fTKLf3iO1?= =?us-ascii?Q?5ut40MRnjeqnrMjD8ev6B3A5kkT+1rnhx87prYBbwqgu56sJ7UwQuiCNCfSo?= =?us-ascii?Q?5tvz6v71comvE7XiATWmhTlm2cf5MVcq55qqn/Q8gnbbN8kg7PN9iL4rtl9Q?= =?us-ascii?Q?/WYv2AP/0paSUh7qxmU/b0wVAO6Y?= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4ad6c94-3f01-45bb-a9b0-08d900b77107 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2021 09:10:12.2728 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TAPdkGmSMRhun19++2LBJRIEDul1dl8d/WSy8EaLdWDoz4WWXu0jAJy8Emq0UhzeE0ysgPg0qBCsvdi/2EHYH3kwCrb0gR01iSJH/RhLkr4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7383 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_021018_853862_7C20F0F8 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 16/04/2021 09:30, Damien Le Moal wrote: > On 2021/04/16 16:13, Johannes Thumshirn wrote: >> On 16/04/2021 05:05, Damien Le Moal wrote: >> >> [...] >> >>> + CRYPT_IV_NO_SECTORS, /* IV calculation does not use sectors */ >> >> [...] >> >>> - if (ivmode == NULL) >>> + if (ivmode == NULL) { >>> cc->iv_gen_ops = NULL; >>> - else if (strcmp(ivmode, "plain") == 0) >>> + set_bit(CRYPT_IV_NO_SECTORS, &cc->cipher_flags); >>> + } else if (strcmp(ivmode, "plain") == 0) >> >> [...] >> >>> + if (!test_bit(CRYPT_IV_NO_SECTORS, &cc->cipher_flags)) { >>> + DMWARN("Zone append is not supported with sector-based IV cyphers"); >>> + ti->zone_append_not_supported = true; >>> + } >> >> I think this negation is hard to follow, at least I had a hard time >> reviewing it. >> >> Wouldn't it make more sense to use CRYPT_IV_USE_SECTORS, set the bit >> for algorithms that use sectors as IV (like plain64) and then do a >> normal > > There are only 2 IV modes that do not use sectors. null and random. All others > do. Hence the "NO_SECTORS" choice. That is the exception rather than the norm, > the flag indicates that. > >> >> if (test_bit(CRYPT_IV_USE_SECTORS, &cc->cipher_flags)) { >> DMWARN("Zone append is not supported with sector-based IV cyphers"); >> ti->zone_append_not_supported = true; >> } >> >> i.e. without the double negation? > > Yes. I agree, it is more readable. But adds more lines for the same result. I > could add a small boolean helper to make the "!test_bit(CRYPT_IV_NO_SECTORS, > &cc->cipher_flags)" easier to understand. > Yes I guessed this was the reason for the choice. Maybe set_bit(CRYPT_IV_USE_SECTORS, &cc->cipher_flags); if (!strcmp(ivmode, "plain") || !strcmp(ivmode, "random")) clear_bit(CRYPT_IV_USE_SECTORS, &cc->cipher_flags); if (test_bit(CRYPT_IV_USE_SECTORS, &cc->cipher_flags)) { DMWARN("Zone append is not supported with sector-based IV cyphers"); ti->zone_append_not_supported = true; } Ultimately it's your and Mikes's call, but I /think/ this makes the code easier to understand. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme