From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A17C4338F for ; Tue, 24 Aug 2021 03:47:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 896D26125F for ; Tue, 24 Aug 2021 03:47:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 896D26125F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=USaqS6Up2rmWaayhh14D9wwuysOwLmzYXzzPQ9qOZzE=; b=jKb6vUBPen7dyd EdKqb1a3iv+aovLBVEsSl8BnEAJGmcQp2V3nKwWX/bTckcD3TspFG0sBxQKErYb7JbbGLxc7svGg5 WvEuXQoVK6X5AgtvKTbO/RiUt7a7DeHWDqldBuHgfwsQEekpGLbPMtUY+OhvbBT1n7eMfjFmggVT6 rBZte91zTjW7b544I3TnMI+vbRzGoMbyNUcEYL+JDF+lh54JAol3G9oa1ymnRFdaDxqx5m/4IAxF5 Z4S9xBugQsnoch5PNqjyCUCvctLnaCrwdqAxJqnebTVmLKGSPxMxVPtvFYNRj9AYnjv+09KWLEe8K YAaq8J/fwbSSZDuK8Lhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mINOp-001SJE-4e; Tue, 24 Aug 2021 03:46:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mINOm-001SI0-FD for linux-nvme@lists.infradead.org; Tue, 24 Aug 2021 03:46:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629776808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8oKeFpafUKcEEbcaIrs+44Y9vp+vcP0pRkBwCZCrRh0=; b=Z9SmKYCmxUmvdLUPCyaboelSxg3EIs701gvNzekXabUxdryQjfhHD/3lauT/8lGAExmHsG i6beQ7Vpk47HjqmRzgv44Dr1bYmkvu7I6A6LbUIZWdf8hPNQbggV1nkD7N819Y6IEz5G+X 4mDH+OqrdpPYCqqfmK4A2ICe5V8WuDE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-tJua4coPMUymKgxvWCY8uA-1; Mon, 23 Aug 2021 23:46:46 -0400 X-MC-Unique: tJua4coPMUymKgxvWCY8uA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EC691F2DC; Tue, 24 Aug 2021 03:46:45 +0000 (UTC) Received: from T590 (ovpn-8-25.pek2.redhat.com [10.72.8.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87E685C232; Tue, 24 Aug 2021 03:46:37 +0000 (UTC) Date: Tue, 24 Aug 2021 11:46:32 +0800 From: Ming Lei To: Saurav Kashyap Cc: Sagi Grimberg , Nilesh Javali , "martin.petersen@oracle.com" , "linux-nvme@lists.infradead.org" , "linux-scsi@vger.kernel.org" , GR-QLogic-Storage-Upstream Subject: Re: [PATCH 0/2] qla2xxx - add nvme map_queues support Message-ID: References: <20210823125649.16061-1-njavali@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_204652_626174_EB2A8AD1 X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Aug 24, 2021 at 03:38:24AM +0000, Saurav Kashyap wrote: > Hi Sagi, > Comments inline > > > -----Original Message----- > > From: Sagi Grimberg > > Sent: Monday, August 23, 2021 10:51 PM > > To: Nilesh Javali ; martin.petersen@oracle.com; linux- > > nvme@lists.infradead.org; Ming Lei > > Cc: linux-scsi@vger.kernel.org; GR-QLogic-Storage-Upstream > Storage-Upstream@marvell.com> > > Subject: Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > > > > > On 8/23/21 5:56 AM, Nilesh Javali wrote: > > > Currently nvme fc doesn't support map queue functionality. This patch > > > set adds map_queue functionality to nvme_fc_mq_ops and > > > nvme_fc_port_template, providing an option to LLDs to map queues > > > similar to SCSI. For qla2xxx, minimum 10% improvement is noticed > > > with this change as it helps in reducing cpu thrashing. > > > > Does this make nvme-fc use managed irq? > > qla2xxx driver uses pci_alloc_irq_vectors_affinity to have affinity with each MSI-X vector. Currently nvme queue are not mapped based on affinity and irq offset. The change is to use blk_mq_pci_map_queues for mapping, this function consider irq affinity as well as irq offset. > OK, got it. Even though without this patchset, nvme-fc actually relies on managed irq since qla2xxx driver uses pci_alloc_irq_vectors_affinity. Now the patchset[1] isn't good for addressing the issue in blk_mq_alloc_request_hctx(). [1] https://lore.kernel.org/linux-block/YR7demOSG6MKFVAF@T590/T/#t Thanks, Ming _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme