From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2425FC433EF for ; Wed, 6 Oct 2021 16:06:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D92B6610C8 for ; Wed, 6 Oct 2021 16:06:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D92B6610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=movementarian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dq0ubQkz7OUTEgWf8r5kdQ9p+7ct0cUHrZTzVxaFZio=; b=awfBQqjJX8K7+h sW4GZE9aoa181YAZ5jodqZODDNAooOfmGek8pNvlqIA2q4xtO+pHLtt9sPZ+qwmVnDLFjBmmscVl/ cfTAtyyDqUKb/nUK7i0exiucx9QjFqVEHH4RyLbHrx/3tYHqkBZ+XN5vEVXsOnjDmUVQpp5KxoCaq RY+uy6KhfMHajY+MBTMwrTmNUP3pwooWyUnhTOCBLN7A/x7poLOuVSVhZ0BM8f3S2/X0D9SjrpRFT VhyFd8WVVoGbinyrKSGrPkZ+6miJXIEpHVsTMfPJwOHU2oj0nt1efjkWRLPUohTg81KH3vfiy1Mc+ 6vOXGBktrIDJhHKUqFtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY9QZ-00EvJp-9N; Wed, 06 Oct 2021 16:05:55 +0000 Received: from ssh.movementarian.org ([139.162.205.133] helo=movementarian.org) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY9QW-00EvIu-Si for linux-nvme@lists.infradead.org; Wed, 06 Oct 2021 16:05:54 +0000 Received: from movement by movementarian.org with local (Exim 4.94) (envelope-from ) id 1mY9QP-0006ga-KE; Wed, 06 Oct 2021 17:05:45 +0100 Date: Wed, 6 Oct 2021 17:05:45 +0100 From: John Levon To: Keith Busch Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me Subject: Re: [PATCH 1/3] nvme-pci: clear shadow doorbell memory on resets Message-ID: References: <20200427235243.2268765-1-kbusch@kernel.org> <20211006120734.GA417782@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211006120734.GA417782@dhcp-10-100-145-180.wdc.com> X-Url: http://www.movementarian.org/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_090552_948197_B023D4C6 X-CRM114-Status: GOOD ( 26.06 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 06, 2021 at 05:07:34AM -0700, Keith Busch wrote: > On Mon, Oct 04, 2021 at 09:35:04AM +0000, John Levon wrote: > > On Mon, Apr 27, 2020 at 04:52:41PM -0700, Keith Busch wrote: > > > > > The host memory doorbell and event buffers need to be initialized on > > > each reset so the driver doesn't observe stale values from the previous > > > instantiation. > > > > > > Signed-off-by: Keith Busch > > > --- > > > drivers/nvme/host/pci.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > > index cf386c84588b..d388fff9c358 100644 > > > --- a/drivers/nvme/host/pci.c > > > +++ b/drivers/nvme/host/pci.c > > > @@ -228,8 +228,11 @@ static int nvme_dbbuf_dma_alloc(struct nvme_dev *dev) > > > { > > > unsigned int mem_size = nvme_dbbuf_size(dev->db_stride); > > > > > > - if (dev->dbbuf_dbs) > > > + if (dev->dbbuf_dbs) { > > > + memset(dev->dbbuf_dbs, 0, mem_size); > > > + memset(dev->dbbuf_eis, 0, mem_size); > > > return 0; > > > + } > > > > > > dev->dbbuf_dbs = dma_alloc_coherent(dev->dev, mem_size, > > > &dev->dbbuf_dbs_dma_addr, > > > > Hi Keith, we came across this issue recently, and we just found this above > > patch. Was there any specific reason it was never merged? > > I don't recall why this wasn't merged. I can't find this series in my > tree anymore, and it also appears that the mailing list has lost the > original patch set. Do you happen to have the rest of the patch emails? > If so, could you possibly send them to me? I found them via lore: https://lore.kernel.org/linux-nvme/20200427235243.2268765-1-kbusch@kernel.org/ regards john _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme