From: Keith Busch <kbusch@kernel.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
oren@nvidia.com, chaitanyak@nvidia.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/1] nvme: use macro definitions for setting reservation values
Date: Thu, 29 Sep 2022 12:56:30 -0600 [thread overview]
Message-ID: <YzXqXhQaV82ZWyEb@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220929115919.9906-1-mgurtovoy@nvidia.com>
On Thu, Sep 29, 2022 at 02:59:19PM +0300, Max Gurtovoy wrote:
> +/*
> + * Reservation Type Encoding
> + */
> +enum {
> + NVME_PR_WRITE_EXCLUSIVE = 1, /* Write Exclusive Reservation */
> + NVME_PR_EXCLUSIVE_ACCESS = 2, /* Exclusive Access Reservation */
> + NVME_PR_WRITE_EXCLUSIVE_REG_ONLY = 3, /* Write Exclusive - Registrants Only Reservation */
> + NVME_PR_EXCLUSIVE_ACCESS_REG_ONLY = 4, /* Exclusive Access - Registrants Only Reservation */
> + NVME_PR_WRITE_EXCLUSIVE_ALL_REGS = 5, /* Write Exclusive - All Registrants Reservation */
> + NVME_PR_EXCLUSIVE_ACCESS_ALL_REGS = 6, /* Exclusive Access - All Registrants Reservation */
> +};
The comments are unnecessary, and this would be more readable if the values
were tab aligned like 'enum pr_type'.
Otherwise looks good.
prev parent reply other threads:[~2022-09-29 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:59 [PATCH 1/1] nvme: use macro definitions for setting reservation values Max Gurtovoy
2022-09-29 18:47 ` Sagi Grimberg
2022-09-29 18:56 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzXqXhQaV82ZWyEb@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).