From: Keith Busch <kbusch@kernel.org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Tejun Heo <tj@kernel.org>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: lockdep WARNING at blktests block/011
Date: Mon, 3 Oct 2022 09:28:36 -0600 [thread overview]
Message-ID: <Yzr/pBvvq0NCzGwV@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20221003133240.bq2vynauksivj55x@shindev>
On Mon, Oct 03, 2022 at 01:32:41PM +0000, Shinichiro Kawasaki wrote:
>
> BTW, I came up to another question during code read. I found nvme_reset_work()
> calls nvme_dev_disable() before nvme_sync_queues(). So, I think the NVME
> controller is already disabled when the reset work calls nvme_sync_queues().
Right, everything previously outstanding has been reclaimed, and the queues are
quiesced at this point. There's nothing for timeout work to wait for, and the
sync is just ensuring every timeout work has returned.
It looks like a timeout is required in order to hit this reported deadlock, but
the driver ensures there's nothing to timeout prior to syncing the queues. I
don't think lockdep could reasonably know that, though.
next prev parent reply other threads:[~2022-10-03 15:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 0:19 lockdep WARNING at blktests block/011 Shinichiro Kawasaki
2022-09-30 11:06 ` Tetsuo Handa
2022-10-03 13:32 ` Shinichiro Kawasaki
2022-10-03 15:28 ` Keith Busch [this message]
2022-10-04 10:44 ` Shinichiro Kawasaki
2022-10-04 11:10 ` Tetsuo Handa
2022-10-04 12:23 ` Shinichiro Kawasaki
2022-10-05 8:31 ` Shinichiro Kawasaki
2022-10-05 10:00 ` Tetsuo Handa
2022-10-05 14:20 ` Keith Busch
2022-10-06 2:30 ` Shinichiro Kawasaki
2022-10-07 1:36 ` Shinichiro Kawasaki
2022-10-04 22:34 ` Damien Le Moal
2022-10-07 20:34 ` Bart Van Assche
2022-10-10 13:31 ` Keith Busch
2022-10-11 17:11 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzr/pBvvq0NCzGwV@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=shinichiro.kawasaki@wdc.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).