From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, hare@suse.de, hch@lst.de,
sagi@grimberg.me
Subject: Re: [PATCH V2] nvme-fabrics: fix I/O connect error handling
Date: Tue, 13 Feb 2024 09:32:05 -0700 [thread overview]
Message-ID: <ZcuZhX4VtRNyeYKi@kbusch-mbp.mynextlight.net> (raw)
In-Reply-To: <20240213082646.49308-1-kch@nvidia.com>
On Tue, Feb 13, 2024 at 12:26:46AM -0800, Chaitanya Kulkarni wrote:
> In nvmf_connect_io_queue(), if connect I/O command fails, we log the
> error and continue for authentication. This overrides error captured
> from __nvme_submit_sync_cmd(), causing wrong return value.
>
> Add goto out_free_data after logging connect error to fix the issue.
>
> Fixes: f50fff73d620c ("nvme: implement In-Band authentication")
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Thanks, applied to nvme-6.8.
prev parent reply other threads:[~2024-02-13 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 8:26 [PATCH V2] nvme-fabrics: fix I/O connect error handling Chaitanya Kulkarni
2024-02-13 16:32 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcuZhX4VtRNyeYKi@kbusch-mbp.mynextlight.net \
--to=kbusch@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).