From: Keith Busch <kbusch@kernel.org>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
hch@lst.de, kch@nvidia.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v7 1/1] nvmet: support reservation feature
Date: Tue, 27 Feb 2024 20:21:22 -0700 [thread overview]
Message-ID: <Zd6msstIWsNQMPfK@kbusch-mbp> (raw)
In-Reply-To: <0c74a2c2-c9d9-4b0c-9deb-bdc3caf72005@linux.alibaba.com>
On Wed, Feb 28, 2024 at 10:21:57AM +0800, Guixin Liu wrote:
>
> 在 2024/2/28 08:40, Sagi Grimberg 写道:
> > Hey Guixin,
> >
> > On 01/02/2024 4:32, Guixin Liu wrote:
> > > This patch implements the reservation feature, includes:
> > > 1. reservation register(register, unregister and replace).
> > > 2. reservation acquire(acquire, preempt, preempt and abort).
> >
> >
> > Overall patchset looks in decent shape to me now.
> >
> > I do have one more question though.
> My thanks for your patient review.
> >
> > You say that this patchset implements preempt and abort, however I don't
> > see how this is actually implemented or even how can it be implemented
> > at all at this point.
>
> Yes, the nvme target does not do any useful workto abort command, the
> comment of nvmet_execute_abort() says that
>
> "we are not required to do any useful work, and we couldn't really do a
> useful abort",
>
> so I don't know what to do about preempt and abort, and the NVMe spec says
> that the abort is best effor.
>
> My statement here may be a little inaccurate.
I think you may be mixing up the NVMe "Abort" command with a different
command, "Reservation Acquire", where RACQA is set to value 010b,
"Preempt and Abort".
next prev parent reply other threads:[~2024-02-28 3:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 2:32 [PATCH v7 0/1] Implement the NVMe reservation feature Guixin Liu
2024-02-01 2:32 ` [PATCH v7 1/1] nvmet: support " Guixin Liu
2024-02-28 0:40 ` Sagi Grimberg
2024-02-28 2:21 ` Guixin Liu
2024-02-28 3:21 ` Keith Busch [this message]
2024-02-28 3:40 ` Guixin Liu
2024-03-07 9:27 ` Sagi Grimberg
2024-03-07 9:42 ` Guixin Liu
2024-03-08 9:15 ` Guixin Liu
2024-03-08 10:07 ` Sagi Grimberg
2024-03-11 11:19 ` Guixin Liu
2024-03-12 21:31 ` Sagi Grimberg
2024-03-13 3:42 ` Guixin Liu
2024-03-13 9:54 ` Sagi Grimberg
2024-03-13 11:56 ` Guixin Liu
2024-03-13 12:36 ` Sagi Grimberg
2024-03-14 2:03 ` Guixin Liu
2024-03-19 2:59 ` Chaitanya Kulkarni
2024-03-19 3:19 ` Guixin Liu
2024-03-20 1:59 ` hch
2024-03-20 9:16 ` Sagi Grimberg
2024-03-21 8:06 ` Chaitanya Kulkarni
2024-03-21 21:02 ` hch
2024-03-22 9:34 ` Chaitanya Kulkarni
2024-03-23 20:41 ` Sagi Grimberg
2024-02-18 2:12 ` [PATCH v7 0/1] Implement the NVMe " Guixin Liu
2024-02-26 6:33 ` Guixin Liu
2024-02-26 6:43 ` Chaitanya Kulkarni
2024-02-29 2:57 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd6msstIWsNQMPfK@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).