From: Hannes Reinecke <hare@suse.de>
To: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: add error message on mismatching controller ids
Date: Fri, 22 Nov 2019 15:40:00 +0100 [thread overview]
Message-ID: <a127cc4a-3f50-ce39-8acb-035bc32fd895@suse.de> (raw)
In-Reply-To: <20191121175810.19501-1-jsmart2021@gmail.com>
On 11/21/19 6:58 PM, James Smart wrote:
> We've seen a few devices that return different controller
> id's to the Fabric Connect command vs the Identify(controller)
> command. It's currently hard to identify this failure by
> existing error messages. It comes across as a (re)connect
> attempt in the transport that fails with a -22 (-EINVAL)
> status. The issue is compounded by older kernels not having
> the controller id check or had the identify command overwrite
> the fabrics controller id value before it checked. Both resulted
> in cases where the devices appeared fine until more recent kernels.
>
> Clarify the reject by adding an error message on controller
> id mismatches.
>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
> drivers/nvme/host/core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 9696404a6182..c272afb084d1 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2824,6 +2824,10 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)
> * admin connect
> */
> if (ctrl->cntlid != le16_to_cpu(id->cntlid)) {
> + dev_err(ctrl->device,
> + "Mismatching cntlid: Connect %u vs Identify "
> + "%u, rejecting\n",
> + ctrl->cntlid, le16_to_cpu(id->cntlid));
> ret = -EINVAL;
> goto out_free;
> }
>
Indeed, we've seem them too.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-22 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 17:58 [PATCH] nvme: add error message on mismatching controller ids James Smart
2019-11-21 19:28 ` Ewan D. Milne
2019-11-21 20:16 ` Chaitanya Kulkarni
2019-11-22 14:40 ` Hannes Reinecke [this message]
2019-11-26 16:51 ` Christoph Hellwig
2019-11-26 17:39 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a127cc4a-3f50-ce39-8acb-035bc32fd895@suse.de \
--to=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).