From: Max Gurtovoy <maxg@mellanox.com>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: axboe@kernel.dk, keith.busch@intel.com,
martin.petersen@oracle.com, israelr@mellanox.com,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
shlomin@mellanox.com
Subject: Re: [PATCH 3/4] nvme-tcp: introduce nvme_tcp_complete_rq callback
Date: Wed, 4 Sep 2019 12:02:30 +0300 [thread overview]
Message-ID: <a2cb1685-2e44-ae7d-5586-b24d9f332ac4@mellanox.com> (raw)
In-Reply-To: <20190904055419.GD10553@lst.de>
On 9/4/2019 8:54 AM, Christoph Hellwig wrote:
> On Tue, Sep 03, 2019 at 12:15:48PM -0700, Sagi Grimberg wrote:
>>> The nvme_cleanup_cmd function should be called to avoid resource leakage
>>> (it's the opposite to nvme_setup_cmd). Fix the error flow during command
>>> submission and also fix the missing call in command completion.
>> Is it always called with nvme_complete_rq? Why not just put it there?
> Yes, unless I am missing something we could call nvme_cleanup_cmd
> at the beginning of nvme_complete_rq.
This will cause change is error flow in nvme_fc but I can check this.
>
> Max, can you send one series for all the nvme_cleanup_cmd fixes and
> cleanups and split that from the PI work? That might be a little
> less confusing.
Yes I will. There is a connection between the patches but for now only
the nvme-pci supports T10 in the nvme subsystem, we can separate them.
There will be still a small gap in the error flow of the pci driver that
will call nvme_cleanup_cmd and do the t10 remap that he shouldn't (but
that's the behavior today)
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-04 9:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 15:14 [PATCH 1/4] block: centrelize PI remapping logic to the block layer Max Gurtovoy
2019-09-03 15:14 ` [PATCH 2/4] nvme-rdma: simplify error flow in nvme_rdma_queue_rq Max Gurtovoy
2019-09-04 5:51 ` Christoph Hellwig
2019-09-03 15:14 ` [PATCH 3/4] nvme-tcp: introduce nvme_tcp_complete_rq callback Max Gurtovoy
2019-09-03 19:15 ` Sagi Grimberg
2019-09-04 5:54 ` Christoph Hellwig
2019-09-04 9:02 ` Max Gurtovoy [this message]
2019-09-03 15:14 ` [PATCH 4/4] nvmet-loop: fix possible leakage during error flow Max Gurtovoy
2019-09-04 5:50 ` Christoph Hellwig
2019-09-03 19:11 ` [PATCH 1/4] block: centrelize PI remapping logic to the block layer Sagi Grimberg
2019-09-03 19:21 ` Jens Axboe
2019-09-04 5:49 ` Christoph Hellwig
2019-09-04 8:32 ` Max Gurtovoy
2019-09-04 12:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2cb1685-2e44-ae7d-5586-b24d9f332ac4@mellanox.com \
--to=maxg@mellanox.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).