From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C285C38A02 for ; Sun, 30 Oct 2022 20:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/fo1hEsQu3o3+5qRF0napZ5OjHJGapII+rFecJ40ZPc=; b=y82wRCEmQDlDOPDzFKHX1/ZpdC kByDxvxT7OxE/mNQkBjXonH2lv5ppIHW4M51VLlU4xEipHSGpQuGmv3A34k1BCUANAn5ZBdjLN5sX IDrDhZ/sD40JzbIIFBPJwt0Pokr2V+CdcfLBmVYhFbmDor8a338ePYmgIkRUy/5Qb+4S7M/S0n+qm iCaVWNWWP48JIM608kXNyIl53IDCC1duV+YHQ+hFgDxQe3rdcxUr9AKRD9355QP4xkA70mQFcPScE yhcVcj0IeDizxWCoXoOQJImuAOBJuUYyTe4FSGWu7Cq/cfCNmiVnMF+m1TOX+6MBL3FKxxYwcNvmc lc14YRnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opFDN-0030sz-EL; Sun, 30 Oct 2022 20:47:29 +0000 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opFDJ-0030q4-Iy for linux-nvme@lists.infradead.org; Sun, 30 Oct 2022 20:47:28 +0000 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29U8ETV0012622; Sun, 30 Oct 2022 20:47:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=/fo1hEsQu3o3+5qRF0napZ5OjHJGapII+rFecJ40ZPc=; b=quk6HRznWWA7ik/taAU4NEVTlVNj7Vm1AYngQ4WL19V65mj+4yS2fybh0QBcKwYKGtA4 e1dg0/ghQ12ERBZHLLROzAkDK5LKUvQf3Ob+nbQjwz2Ut5aSYc5Xh9y8GyPrwzhNApWv 6VuLpNxg89/axKXMyD4VXEb7VUsAOsrP7KoN6UdYJq8QcJasJVgHTkzltromOylB/VsW pJLVHIAGr/3kpBw7f/nWd0dNpMmKsQAldmzafl04cbJR3RiCrvWrL+iR01KojzFUazSm 6Cwh2ozPtWLPctCSIdcYGUFDlENXQXyC301ooCJdehE3OmsJkbiC0RcDFBDquEoLyKBe WA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kgts11yum-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 30 Oct 2022 20:47:12 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 29UCnQD8023892; Sun, 30 Oct 2022 20:47:11 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2049.outbound.protection.outlook.com [104.47.73.49]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kgtm2kg2w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 30 Oct 2022 20:47:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrmfwvfTm+zR6RoJbzZUE/QfwGrkV/sAP86CqH5QedEqKV9Xv+4e8uqnqtRqFqGSRUdOUacg5OQC0CPJcimQjFYdOBxxwM9w1kGHejP4gtbgF8yu84o18+I1XARqqVT/XeOFuGPhe3xVjPfSlACm/YbK/sDfuBXMHGPNc4Ji8OLWSjbr1XkInc0mz95DNa6OmoKGHicWfPGjjZ9D3gDSvyE96DrkjvRgDjNuwhA0OjuMOT82t2bzj5dn73inr3zGnnP11pIOV991TAMnxfmKBcEsokaBLrjZkbRClC9PBSFN9rwhDiOIKZB2inSMQ17nOe/yi6HKpwtQoJ3Bc+/39A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/fo1hEsQu3o3+5qRF0napZ5OjHJGapII+rFecJ40ZPc=; b=TUzPYg+rVf2OAAlImaZsde73Wyj6xZbred53x4rTHmFm2ixjydwXITgRuI9vwt0w3MoojSmNoNRGbyE1H5I1V1KXQpl4Ypk2HC7pOV08Is+Dg8XL6HoouajfXUn4U8bo3aUDh/st2hJj5vdQYuDYgaWwlPlDK6AEUjH/n75mzQeNN6CgO9dJ2LDFcPYdfhVrEfrQUi+0lJaMvx7EEJf73xqjMG4/NSH1bw5mqSPQkKtujtccfnGwCCf5MAnJWq+rp3Dw+a8RhPWHKE8dMpE/3Vx08h2390PfJmg2DnxrJUZjxwS65mcCuCBsnOKsyKlSf6+FyiQSsYyk40VokzHWmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/fo1hEsQu3o3+5qRF0napZ5OjHJGapII+rFecJ40ZPc=; b=QpfWQAvxiy4RTDLYP20GNJ1FvTLBueY5PIFyWVasSa86EO5fe3dEriGgjQr7XImhkwDlkAFY7BoTRB3imUYeS2MqJXFzxY0mTCNc7EppvyO6KgdBRIojP6SDOvxVMHi1v4QjWDZI9hNuXA93PCvpdHg+xGq5z2gIOO/ykQWyqZA= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by BN0PR10MB5046.namprd10.prod.outlook.com (2603:10b6:408:127::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Sun, 30 Oct 2022 20:47:09 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::19f7:e081:85b4:c5df]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::19f7:e081:85b4:c5df%7]) with mapi id 15.20.5769.019; Sun, 30 Oct 2022 20:47:08 +0000 Message-ID: Date: Sun, 30 Oct 2022 15:47:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v3 09/19] nvme: Add pr_ops read_keys support To: Christoph Hellwig Cc: bvanassche@acm.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com, linux-block@vger.kernel.org, dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk, linux-nvme@lists.infradead.org, chaitanyak@nvidia.com, kbusch@kernel.org, target-devel@vger.kernel.org References: <20221026231945.6609-1-michael.christie@oracle.com> <20221026231945.6609-10-michael.christie@oracle.com> <20221030081708.GA4774@lst.de> Content-Language: en-US From: Mike Christie In-Reply-To: <20221030081708.GA4774@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR14CA0058.namprd14.prod.outlook.com (2603:10b6:610:56::38) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR10MB1466:EE_|BN0PR10MB5046:EE_ X-MS-Office365-Filtering-Correlation-Id: e9dbf366-7de5-471c-8a0f-08dabab7e905 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OA8DFzxccpkn1Up1gQA1WHnJMq4e/0KPqGx8YxbmBZFvqCKLUq8AuKp6s5vX5rDGjUsooPnXyhgJjOMulepfjPTzIIzRHUC6FXOXpXcJeEUoDPyjrOrbVSwg3FSwu47ya0iMUklK16cGxI81lOkMG1W4X1OhDUXQt1TS5slDyFi0kfkQcEyGstPxQxWDWTO3bkgg1ss8WqfPHATWXZN+7YBGWVwdLsKsHPgMg1chxcw6f9aObW+2iHG1foh1EbIUbTTA1rJCbLhaM9YMtBVA8i/gwC9twYUbYAuPbYjjpcVwoMIGcl5YURrIIqb8BSDBRAOMHKs2RDzLDjLEBw/I96iQqbI2wJegxHK1PEKEpOukkBSDyEzSh0d7F1vb/nW7Vk/yVdYRfA/sTUXYvsLQ9jJk1P5BPYm1sv0j6O1TYP3gZmVGjSsv7td8W1KZ91UaU8h5aF4Woj/T5dKCol9bqZRxP4ZQYXlQtD8GmL6IbTD+Kr8dE7j9KGseBfEkFYCWKRBWgSrOEoTLb7eIOhNCWQ3bO6fNv1IvxtOTcg5SnWX4+w6cg+YPor9F0pcV/ytMUwU8dK9rUtKM6+NT1r4/R7bjv26g7u1IQgALwx2/QncbjPnaNrgNeL1YpyRuJD0aF8yvoHeY00dsTx9/TduWJ5A6OOxz3gwPh43FUmBmfVMS3ATTVcC1oTBGc97qsEjaIoNR+Lnzv8eVPB5dH0qtQBV6VrDk1GeFkuYi9PAlWvSMoECtEjHjCsqjIitcAavSy+Q+FmtR1lLG39dN+2ECE9MKuierD/nqFk2d2659uH0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(26005)(53546011)(36756003)(6506007)(186003)(6512007)(2616005)(2906002)(478600001)(6486002)(38100700002)(86362001)(31696002)(83380400001)(316002)(31686004)(8936002)(66946007)(66476007)(66556008)(8676002)(6916009)(4326008)(41300700001)(7416002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RG1Vc1RYcG05RXpqSXF1azdGc1VOS2M1QmZpTFRkRFdRNld5ZUx5eFpVSzBH?= =?utf-8?B?MHRmdG5XWkNYaTRtRk5RSE5sNS8wVzBRSm1WQ1ZwR25xQ01IZ0k4VW8wUUhP?= =?utf-8?B?VGF0dDJZZ0xta2lRa1FxbjB2dlJya3dJeEtTbVlmUHdCaFN4OGNrNmE0Q1Mv?= =?utf-8?B?K2Y4TERuYnFWc2xKUXYxTHBBb2NmQXNVbEptb3JTOWEyOEhzOUcwbFRaU3Az?= =?utf-8?B?L1lTcGovRzJKVm00TlZhN1k3WTBBeG9HanE3QzVKeDF4OTlXUlN4SERFaGZ5?= =?utf-8?B?ekZ4WElaalZyY2ZtdGh1enZoWnBrRlNuWk5reTlPOFFORDNxZmtZSzRPZTBt?= =?utf-8?B?STRpSzU0dHA2WlU1UnhyakIzOUFSZ3lsU1hEbTN0ejVHdmlPZnNzMGVlSFc4?= =?utf-8?B?VnQ2WExmWWlnVXg5b3IzcmJWYk1BdHQ3UVNrckNNbjRHemhoNTBGWmN4T2dR?= =?utf-8?B?ekxmUENNcFVQZGs3ODZ2cHJFSDRiT3h1ZEVWVk53dXJwU0ZDTURnT1h4VjIr?= =?utf-8?B?YWlWdVhDZlB0MW9LSndMTUowNDE1Ry95cm8rczB6ZXJrczN2OE1tRnNIOFJ6?= =?utf-8?B?Y3B1eDRkaldVR3Y4UUlFOHd4dWZuVWhxQXNEbEFrNzBvb1lXRmYvcWg0SGtM?= =?utf-8?B?clFyUTREcDdqb01LZWdUWTdjRS9PRkVmZHJBbnlOcVBJR3Q1aEZGVnptVjdC?= =?utf-8?B?S1A4dVdQS08xYk05UHdSb1BjVTNGbWZOYnB6YllaWXdGQ0t6azkxbFN1TmEr?= =?utf-8?B?ejQvT1VQMjFYSWJjam5JUGFCMlNuckF3RlhzakJPNzJBeG90Z2REaUwxT1Fj?= =?utf-8?B?ejMzTG5HWk05MENzRUFiU1VpSjFEWngzdGRGRTE1Rm1MbUV1a0hzamIvTnJI?= =?utf-8?B?UTdLMGt5RFY2ekdSRWVIUExaSnVPZ1ZMeDdQQWUvOEhMMXpVeVlXcHU4Sk9T?= =?utf-8?B?aDlTM2FjdnF0ZmQvSDhmb1pDdTY2ZXV2OGZDU1JVUzk4a20vY21GeTZyd2gy?= =?utf-8?B?U09JaGJWWTZrcFpDbWpvNTA2MVdFbzZkdDk4MDBLL3RvdlZ1NUV5RENURzYy?= =?utf-8?B?RUJkdVFLZ25xQkd1emNOVXVjT0pteDVNODVGMHN4RVhsb3ZFYnJxNU81YkV3?= =?utf-8?B?dzhOc2V3MlYyMERrRmMwQVFCYjJaSHB2Y3V5eU55Y2k3L2hXTUVqYlhXNk83?= =?utf-8?B?VDdTRUV6V0RHMUlkc09OUkVzYUNTWklPZzdkc2E5MkdmOGgvYnVuSFRTTHNN?= =?utf-8?B?bFpjWndDRUp3bFR6S0Zxb1ZEdy9tTE5xc1FCV2xqMzVQWi82dE1xbldKMStr?= =?utf-8?B?K0xzQmFUNm9rbXQ3N1FTVlRKem5xQUxFQnRuajhPZ0x2di9NQ240eW9FUE16?= =?utf-8?B?NXZrQ2YrVVJJUisrdCtwZG9jM3luR0FGWDBVN2RlVGgzVjFrUStVSUJPbmYw?= =?utf-8?B?SkpBQkhPWUszWjh2WW1DalJDSko1b29DL2Z0d2pwTm9pemoxaVF6UUxUQTNM?= =?utf-8?B?b3NJeDlUSEZUcnZHMXdiNVIwVm9xRHZNWFV2TnBZM05wRjR0VXJSazRsVVAr?= =?utf-8?B?bGYvTDY4QmwxajFZcUdhV1Jlb0l0eTVDWFZacUI1T0RQSDY4VzVBSTNTQU1C?= =?utf-8?B?emIvMU5mcnhXcWhEdUFDUTl5dUtUMVJEM1p3UHBVZTVKcTV2QnZYT2xLdEFC?= =?utf-8?B?a0pJNFFJZjA2U3VwRk1OMGoxaVBYUVJsZzQyazhwZ3VKaWhFUlRVM05MWjB4?= =?utf-8?B?d1UvajBqeUVPQkRTaFp2QlZ6WERNVE4xQ3dHMGJjbEZuR2VhUWd1Q0hCeDRY?= =?utf-8?B?Q1FYWjJMYXJ1WEVYRUNuMWFLYUQ2RjByZVgrcXNmYkxkM2tNZDJkNnkydWlU?= =?utf-8?B?T0dWMFlYVWFJU2JjVi8vYU5xblIwSFdIVGxkTFEvV2dxSFFWTkVpZDIwQlJu?= =?utf-8?B?bWJkcDJPZDFUamtpemtFdkM1RmJRa0lSTCtvN2FmUnArQzkwZGVuQVhkWndq?= =?utf-8?B?Y2lCL0lZVUk0UEFiTStPSlpmKzc2aHZWc1FqT3pSemRPVU1xQUtBYlZyem9l?= =?utf-8?B?RFNEbkRnZFpySkNHSWJEY05mdnpYMmNTbGVZbCtuRXZZcGJVbUhZa01uNGlW?= =?utf-8?B?ekJPTE9OcTB6NlpYVWRCcmtzQkpIL1pPOUtvNnQ2NzlTNUdWUCtqLy96VzZj?= =?utf-8?B?WUE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9dbf366-7de5-471c-8a0f-08dabab7e905 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2022 20:47:07.9300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pv69yP40N6jX3aM1TOSYqY/IquGuFRwwUFI9EFgOANeJFa8HAeLR7h8ElbG7HhesjgBHytB0MMDOjvfIflDDr39lVpUGnbWYHSMFR4hCUiY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5046 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-30_14,2022-10-27_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2210300140 X-Proofpoint-GUID: vvBj8ECQLd-tkf7IQzFUFMycoKjrFvFp X-Proofpoint-ORIG-GUID: vvBj8ECQLd-tkf7IQzFUFMycoKjrFvFp X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221030_134726_581570_2EF766C0 X-CRM114-Status: GOOD ( 32.81 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 10/30/22 3:17 AM, Christoph Hellwig wrote: > On Wed, Oct 26, 2022 at 06:19:35PM -0500, Mike Christie wrote: >> This patch adds support for the pr_ops read_keys callout by calling the >> NVMe Reservation Report helper, then parsing that info to get the >> controller's registered keys. Because the callout is only used in the >> kernel where the callers do not know about controller/host IDs, the >> callout just returns the registered keys which is required by the SCSI PR >> in READ KEYS command. >> >> Signed-off-by: Mike Christie >> --- >> drivers/nvme/host/pr.c | 73 ++++++++++++++++++++++++++++++++++++++++++ >> include/linux/nvme.h | 4 +++ >> 2 files changed, 77 insertions(+) >> >> diff --git a/drivers/nvme/host/pr.c b/drivers/nvme/host/pr.c >> index aa88c55879b2..df7eb2440c67 100644 >> --- a/drivers/nvme/host/pr.c >> +++ b/drivers/nvme/host/pr.c >> @@ -118,10 +118,83 @@ static int nvme_pr_release(struct block_device *bdev, u64 key, enum pr_type type >> return nvme_pr_command(bdev, cdw10, key, 0, nvme_cmd_resv_release); >> } >> >> +static int nvme_pr_resv_report(struct block_device *bdev, u8 *data, >> + u32 data_len, bool *eds) > > Is there any good reason this method seems to take a u8 instead of a void > pointer? As that seems to make a few things a bit messy. I did it because the helper functions nvme_send_ns_head_pr_command/ nvme_send_ns_pr_command took a u8. Looking at it some more I see those functions use nvme_submit_sync_cmd which then takes a avoid pointer. To handle your comment about the helper below I'll fix all that up to take a void pointer. > >> + if (IS_ENABLED(CONFIG_NVME_MULTIPATH) && >> + bdev->bd_disk->fops == &nvme_ns_head_ops) >> + ret = nvme_send_ns_head_pr_command(bdev, &c, data, data_len); >> + else >> + ret = nvme_send_ns_pr_command(bdev->bd_disk->private_data, &c, >> + data, data_len); > > Can you please add a hlper for this logic? Will do. > >> + for (i = 0; i < num_ret_keys; i++) { >> + if (eds) { >> + keys_info->keys[i] = >> + le64_to_cpu(status->regctl_eds[i].rkey); >> + } else { >> + keys_info->keys[i] = >> + le64_to_cpu(status->regctl_ds[i].rkey); >> + } > > If you shorten the status variable name to something like rs this becomes > much easier to follow :) Will do.