From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <keith.busch@wdc.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] Add 'gen-dhchap-key' command
Date: Tue, 14 Sep 2021 09:59:01 +0300 [thread overview]
Message-ID: <a8fa8d60-6959-17f2-4f3e-57d37d354b9d@grimberg.me> (raw)
In-Reply-To: <ff32b35b-1346-765b-def9-74656fda8cc3@grimberg.me>
> Yee... it won't be long until we'll hear complaints on this one.
> I think we need to have some simple format like:
> <default>:<def_hostkey>
> <subsystem1>:<hostkey1>
> <subsystem2>:<hostkey2>
> ...
>
> And we will need /etc/nvme/subsyskey in the same format:
> <default>:<def_subsyskey>
> <subsystem1>:<subsyskey1>
> <subsystem2>:<subsyskey2>
> ...
>
> And ideally we also have a way for nvme-cli to populate it in this
> format (or some helper script for it).
>
>> So would just stick with the simple case, and leave this as an
>> exercise to the reader.
>
> Don't know if that is good enough...
> What do others think?
Also, if we expand the format later, we may introduce a pain when
updating nvme-cli...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-14 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 10:24 [PATCH nvme-cli 0/2] Support commands for NVMe In-band authentication Hannes Reinecke
2021-09-13 10:24 ` [PATCH 1/2] Add 'gen-dhchap-key' command Hannes Reinecke
2021-09-13 19:26 ` Sagi Grimberg
2021-09-14 6:18 ` Hannes Reinecke
2021-09-14 6:49 ` Sagi Grimberg
2021-09-14 6:59 ` Sagi Grimberg [this message]
2021-09-13 10:24 ` [PATCH 2/2] Add 'check-dhchap-key' function Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8fa8d60-6959-17f2-4f3e-57d37d354b9d@grimberg.me \
--to=sagi@grimberg.me \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).