From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-raid@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Song Liu <song@kernel.org>,
dm-devel@redhat.com, Jeffle Xu <jefflexu@linux.alibaba.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] [RFC PATCH 2/2] block: support to freeze bio based request queue
Date: Thu, 15 Apr 2021 13:16:42 -0700 [thread overview]
Message-ID: <af8f41f4-74e8-450d-fa63-6feb6b745222@acm.org> (raw)
In-Reply-To: <20210415103310.1513841-3-ming.lei@redhat.com>
On 4/15/21 3:33 AM, Ming Lei wrote:
> 1) grab two queue usage refcount for blk-mq before submitting blk-mq
> bio, one is for bio, anther is for request;
^^^^^^
another?
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 09f774e7413d..f71e4b433030 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -431,12 +431,13 @@ EXPORT_SYMBOL(blk_cleanup_queue);
> int blk_queue_enter(struct request_queue *q, blk_mq_req_flags_t flags)
> {
> const bool pm = flags & BLK_MQ_REQ_PM;
> + const unsigned int nr = (flags & BLK_MQ_REQ_DOUBLE_REF) ? 2 : 1;
Please leave out the parentheses from around the condition in the above
and in other ternary expressions. The ternary operator has a very low
precedence so adding parentheses around the condition in a ternary
operator is almost never necessary.
> @@ -480,8 +481,18 @@ static inline int bio_queue_enter(struct bio *bio)
> struct request_queue *q = bio->bi_bdev->bd_disk->queue;
> bool nowait = bio->bi_opf & REQ_NOWAIT;
> int ret;
> + blk_mq_req_flags_t flags = nowait ? BLK_MQ_REQ_NOWAIT : 0;
> + bool reffed = bio_flagged(bio, BIO_QUEUE_REFFED);
>
> - ret = blk_queue_enter(q, nowait ? BLK_MQ_REQ_NOWAIT : 0);
> + if (!reffed)
> + bio_set_flag(bio, BIO_QUEUE_REFFED);
> +
> + /*
> + * Grab two queue references for blk-mq, one is for bio, and
> + * another is for blk-mq request.
> + */
> + ret = blk_queue_enter(q, q->mq_ops && !reffed ?
> + (flags | BLK_MQ_REQ_DOUBLE_REF) : flags);
Consider rewriting the above code as follows to make it easier to read:
if (q->mq_ops && !reffed)
flags |= BLK_MQ_REQ_DOUBLE_REF;
ret = blk_queue_enter(q, flags);
Please also expand the comment above this code. The comment only
explains the reffed == false case but not the reffed == true case. I
assume that the reffed == true case applies to stacked bio-based drivers?
Thanks,
Bart.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-15 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:33 [RFC PATCH 0/2] block: support to freeze bio based queue Ming Lei
2021-04-15 10:33 ` [RFC PATCH 1/2] percpu_ref: add percpu_ref_tryget_many_live Ming Lei
2021-04-15 19:50 ` Bart Van Assche
2021-04-15 10:33 ` [RFC PATCH 2/2] block: support to freeze bio based request queue Ming Lei
2021-04-15 13:56 ` Ming Lei
2021-04-15 20:16 ` Bart Van Assche [this message]
2021-04-16 1:28 ` [dm-devel] " Ming Lei
2021-04-19 12:05 ` JeffleXu
2021-04-19 13:50 ` Ming Lei
2021-04-20 7:21 ` JeffleXu
2021-04-20 7:58 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af8f41f4-74e8-450d-fa63-6feb6b745222@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).