From: Arun Easi <aeasi@marvell.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>,
<linux-scsi@vger.kernel.org>,
<GR-QLogic-Storage-Upstream@marvell.com>,
<linux-nvme@lists.infradead.org>, Hannes Reinecke <hare@suse.de>,
Nilesh Javali <njavali@marvell.com>,
"James Smart" <james.smart@broadcom.com>
Subject: Re: [EXT] Re: [RFC] qla2xxx: Add dev_loss_tmo kernel module options
Date: Tue, 27 Apr 2021 15:35:47 -0700 [thread overview]
Message-ID: <alpine.LRH.2.21.9999.2104271531440.24132@irv1user01.caveonetworks.com> (raw)
In-Reply-To: <20210427095131.zf6c4siewnrhv7qd@beryllium.lan>
On Tue, 27 Apr 2021, 2:51am, Daniel Wagner wrote:
> On Wed, Apr 21, 2021 at 09:56:59AM +0200, Daniel Wagner wrote:
> > Ah, didn't know about nvmediscovery until very recentetly. I try to get
> > it working with this approach (as this patch is not really a proper
> > solution).
>
> Finally found some time to play with this. FTR, the nvmediscovery
> carries following information:
>
> UDEV [65238.364677] change /devices/virtual/fc/fc_udev_device (fc)
> ACTION=change
> DEVPATH=/devices/virtual/fc/fc_udev_device
> FC_EVENT=nvmediscovery
> NVMEFC_HOST_TRADDR=nn-0x20000024ff7fa448:pn-0x21000024ff7fa448
> NVMEFC_TRADDR=nn-0x200200a09890f5bf:pn-0x203800a09890f5bf
> SEQNUM=12357
> SUBSYSTEM=fc
> USEC_INITIALIZED=65238333374
>
> The udev rule I came up is:
>
> ACTION=="change", SUBSYSTEM=="fc", ENV{FC_EVENT}=="nvmediscovery", \
> ENV{NVMEFC_TRADDR}=="*", \
> RUN+="/usr/local/sbin/qla2xxx_dev_loss_tmo.sh $env{NVMEFC_TRADDR} 4294967295"
>
> and the script is:
>
> #!/bin/sh
>
> TRADDR=$1
> TMO=$2
>
> id=$(echo $TRADDR | sed -n "s/.*pn-0x\([0-9a-f]\+\)/\1/p")
> find /sys/kernel/debug/qla2xxx -name pn-$id -exec /bin/sh -c "echo $TMO > {}/dev_loss_tmo" \;
>
> I am sure this can be done in a more elegant way. Anyway, I am testing
> this right now, the first 30 minutes look good...
>
Looks ok to me. Just keep in mind that, with this you'd be setting all
instances of pn-XXX (multiple initiator ports seeing the same target
scenario). It looks like this is what you want, but thought I'd point that
out.
Regards,
-Arun
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-27 22:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 10:00 [RFC] qla2xxx: Add dev_loss_tmo kernel module options Daniel Wagner
2021-04-19 16:19 ` Randy Dunlap
2021-04-20 12:37 ` Daniel Wagner
2021-04-20 14:51 ` Himanshu Madhani
2021-04-20 15:35 ` Randy Dunlap
2021-04-20 17:27 ` Benjamin Block
2021-04-20 17:35 ` Roman Bolshakov
2021-04-20 18:28 ` Daniel Wagner
2021-04-21 0:25 ` [EXT] " Arun Easi
2021-04-21 7:56 ` Daniel Wagner
2021-04-27 9:51 ` Daniel Wagner
2021-04-27 22:35 ` Arun Easi [this message]
2021-04-28 7:17 ` Daniel Wagner
2021-04-28 14:51 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.9999.2104271531440.24132@irv1user01.caveonetworks.com \
--to=aeasi@marvell.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).