linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
	linux-nvme@lists.infradead.org
Cc: hch@lst.de
Subject: Re: [PATCH V3 1/3] nvmet: make ctrl-id configurable
Date: Wed, 11 Dec 2019 16:45:02 -0800	[thread overview]
Message-ID: <b08812b4-8fa7-d814-cce2-2d8248c233ae@grimberg.me> (raw)
In-Reply-To: <20191127094034.12334-2-chaitanya.kulkarni@wdc.com>


> +static ssize_t nvmet_subsys_attr_cntlid_max_store(struct config_item *item,
> +						  const char *page, size_t cnt)
> +{
> +	int ret = -EINVAL;
> +	u16 cntlid_max;
> +
> +	if (sscanf(page, "%hu\n", &cntlid_max) != 1)
> +		return ret;
> +
> +	if (cntlid_max == 0) {
> +		pr_info("specified cntlid_max = 0 is not allowed\n");
> +		return ret;
> +	}

Check not exceeds unsigned short max value?

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-12-12  0:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  9:40 [PATCH 0/3] nvmet: make model/ctrl-id configurable, configfs fix Chaitanya Kulkarni
2019-11-27  9:40 ` [PATCH V3 1/3] nvmet: make ctrl-id configurable Chaitanya Kulkarni
2019-12-12  0:45   ` Sagi Grimberg [this message]
2019-12-12  9:22     ` Christoph Hellwig
2019-12-12  9:26   ` Christoph Hellwig
2019-12-16 20:40     ` Chaitanya Kulkarni
2019-11-27  9:40 ` [PATCH V4 2/3] nvmet: make ctrl model configurable Chaitanya Kulkarni
2019-12-12  0:45   ` Sagi Grimberg
2019-12-12  9:28   ` Christoph Hellwig
2019-12-12  9:46     ` Christoph Hellwig
2019-12-17  4:53     ` Chaitanya Kulkarni
2019-11-27  9:40 ` [PATCH V2 3/3] nvmet: check sscanf value for subsys serial attr Chaitanya Kulkarni
2019-12-12  0:46   ` Sagi Grimberg
2019-12-12  9:29   ` Christoph Hellwig
2019-12-11  5:35 ` [PATCH 0/3] nvmet: make model/ctrl-id configurable, configfs fix Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b08812b4-8fa7-d814-cce2-2d8248c233ae@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --subject='Re: [PATCH V3 1/3] nvmet: make ctrl-id configurable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).