From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADA0C433E0 for ; Fri, 7 Aug 2020 17:34:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41EB920866 for ; Fri, 7 Aug 2020 17:34:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fU6xb/iw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41EB920866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9MNa7wnveQMFwKatVDR2gNv135UgG5PJSjSEAeZAi6I=; b=fU6xb/iwi7hhGrElZQIGr3m7Y srQxeVqnTU8dblLb+ToZfJGIh53UVtGFNL3Q3Crhpi/UGSVGv7vDBPHx+pugRT/c5opYSpqPDy3mX A6PD4/orp3jU2uxkco3CuYQSTnlxa9bID7iFf6aH4asHk1LTNVyGAUJqW+4LQ987idifEHdbdJNgj 40ap0rjZzbEKsK4AEPoiY6eFwI/KedjOX79I7FucCAOM2DAoxTJw2u0KtiJjzpLINg9XG9iQZ+8zK 4Xlgaawmr1J9hhza8TE6EBE6nBNE9P+X7E/yj6IX/OK7OkXCv718fEqsJrEnDnrelVv4eyMkDbckC mpjOQ3vMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k46GF-0002gn-ED; Fri, 07 Aug 2020 17:34:31 +0000 Received: from mail-pg1-f193.google.com ([209.85.215.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k46GC-0002fg-5j for linux-nvme@lists.infradead.org; Fri, 07 Aug 2020 17:34:29 +0000 Received: by mail-pg1-f193.google.com with SMTP id m34so1242462pgl.11 for ; Fri, 07 Aug 2020 10:34:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=4eN0ni97v3fR7ENINoYmX5MNOweJeUgowKJnRfQHBjE=; b=FJ18OBaLPKrf6c2HiJVkzGcwe4dfhU4VXsBjVGBD0oOiHx30G7jancosuKDNzJBBKv aDdo1vnfcKWb5BO7WIVJ9rDKNwMI2an8L2afCp0qgBTujLKzQqzfT8023q3Jj2e4tMPV yt5849i+ozZQ5hNazJwrizFuq36aPhdKbu2+TZ16ZpNvg0EHa3Pk2gfqHRgoDlYU1F7K 0+O1gkrlIjR90tvUtdfuWq2G5TlJ+3efUHj8QYlW4lhEqseDzsGcHZCAcCwDjnbfSs/m UvofiwnjARwVekNOx4IYhySp2HbwC9qrhsgeScT5U6Zy4cr9En6BiziguZ8PXiPCSoWi ItWA== X-Gm-Message-State: AOAM533FDrTjap5qRgSjaXmav/OoOmYpyQDPqR01ROnMDDa96URg5MP2 Wvs05WqoPYfb0zNx4xP1IEs= X-Google-Smtp-Source: ABdhPJzRYyvJx5R4KZQvTkivVt7Yqr+Ny6+gMf3r3rzdffPCvBIdQfdHG1Qz2f+XWfVw7F09OIGsXw== X-Received: by 2002:aa7:9552:: with SMTP id w18mr14248156pfq.150.1596821666783; Fri, 07 Aug 2020 10:34:26 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id fv21sm11217857pjb.16.2020.08.07.10.34.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 10:34:25 -0700 (PDT) Subject: Re: [PATCH v2 6/7] common/multipath-over-rdma: don't retry module unload To: Sagi Grimberg , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Omar Sandoval References: <20200806191518.593880-1-sagi@grimberg.me> <20200806191518.593880-7-sagi@grimberg.me> <925e1ac6-38fa-6fe9-c0b7-7e665559a989@acm.org> <155cb916-062f-e23f-9790-35dee850687b@grimberg.me> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Fri, 7 Aug 2020 10:34:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <155cb916-062f-e23f-9790-35dee850687b@grimberg.me> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_133428_248848_8EAD1A13 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Johannes Thumshirn , Christoph Hellwig , Chaitanya Kulkarni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2020-08-07 10:23, Sagi Grimberg wrote: > >>> There is no need to retry module unload for rdma_rxe >>> and siw. This also creates a dependency on >>> tests/nvmeof/rc which prevents it from using in >>> other test subsystems. >> >> If it wouldn't be necessary to retry module unload I wouldn't have >> introduced a loop. > > I thought it was to work-around a driver issue as these drivers > traditionally had plenty of stability issues. > > To be honest this retry loop to me indicated that either the > driver has a bug or the test. But maybe there is a need I > am not seeing. That loop was introduced a long time ago. I haven't tried to root-cause it but my guess is that the loop is necessary because the module refcount only drops to zero a short time after the first attempt to unload these kernel modules. Bart. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme