From: Sagi Grimberg <sagi@grimberg.me>
To: Martin Belanger <nitram_67@hotmail.com>, linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de,
Martin Belanger <martin.belanger@dell.com>
Subject: Re: [PATCH 1/1] Add 'Transport Interface' (triface) option. This can be used to specify the IP interface to use for the connection. The driver uses that to set SO_BINDTODEVICE on the socket before connecting.
Date: Tue, 4 May 2021 12:56:51 -0700 [thread overview]
Message-ID: <b47456a5-69ae-1f33-30f0-aa25906668f2@grimberg.me> (raw)
In-Reply-To: <BL0PR13MB42917AC33BFFC7DB2440D1149C4D9@BL0PR13MB4291.namprd13.prod.outlook.com>
> From: Martin Belanger <martin.belanger@dell.com>
Change log is missing...
>
> ---
> drivers/nvme/host/core.c | 5 +++++
> drivers/nvme/host/fabrics.c | 14 +++++++++++++
> drivers/nvme/host/fabrics.h | 6 +++++-
> drivers/nvme/host/tcp.c | 41 ++++++++++++++++++++++++++++++++++---
> 4 files changed, 62 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 288ac47ff5b4..91ae11a1ae26 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3961,6 +3961,11 @@ static int nvme_class_uevent(struct device *dev, struct kobj_uevent_env *env)
>
> ret = add_uevent_var(env, "NVME_HOST_TRADDR=%s",
> opts->host_traddr ?: "none");
> + if (ret)
> + return ret;
> +
> + ret = add_uevent_var(env, "NVME_HOST_TRIFACE=%s",
> + opts->host_triface ?: "none");
Given that this was the original intent for host_traddr, why not have
host_traddr resolve the iface from the address and set sockopt
SO_BINDTODEVICE on it?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-04 19:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210415192848.962891-1-nitram_67@hotmail.com>
2021-04-15 19:28 ` [PATCH 1/1] Add 'Transport Interface' (triface) option. This can be used to specify the IP interface to use for the connection. The driver uses that to set SO_BINDTODEVICE on the socket before connecting Martin Belanger
2021-05-01 11:34 ` Hannes Reinecke
2021-05-03 16:59 ` Belanger, Martin
2021-05-04 13:25 ` Hannes Reinecke
2021-05-04 19:56 ` Sagi Grimberg [this message]
2021-05-05 8:47 ` Hannes Reinecke
2021-05-05 14:31 ` Belanger, Martin
2021-05-05 18:33 ` James Smart
2021-05-05 20:32 ` Sagi Grimberg
2021-05-06 18:27 ` Michael Christie
2021-05-06 6:05 ` Hannes Reinecke
2021-05-06 7:00 ` Hannes Reinecke
2021-05-06 15:46 ` Belanger, Martin
2021-05-07 18:20 ` Sagi Grimberg
2021-05-10 13:49 ` Belanger, Martin
2021-05-10 18:13 ` Sagi Grimberg
2021-05-10 19:18 ` Belanger, Martin
2021-05-11 0:28 ` Sagi Grimberg
2021-05-11 13:41 ` Belanger, Martin
2021-05-11 17:13 ` Sagi Grimberg
2021-05-12 6:09 ` Hannes Reinecke
2021-05-12 12:12 ` Belanger, Martin
2021-05-12 22:12 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47456a5-69ae-1f33-30f0-aa25906668f2@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.belanger@dell.com \
--cc=nitram_67@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).