From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <keith.busch@intel.com>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v8 7/7] nvme: fix ns removal hang when failing to revalidate due to a transient error
Date: Fri, 30 Aug 2019 11:03:55 -0700 [thread overview]
Message-ID: <b4fbecce-f647-71c2-45fc-00352734e4ca@grimberg.me> (raw)
In-Reply-To: <20190830055435.GB8492@lst.de>
>>> After looking into various revalidate_disk refactoring I think we could
>>> do something simple like this to just ignore the non-fatal errors
>>> (won't apply as is, but you get the idea):
>>
>> This will quietly ignore errors even for the routine ns allocation path,
>> do we want that to happen?
>
> Why not? Why would we treat an -ENOMEM or transport error different
> when doing a scanning (e.g. because we have to reconnect) vs just when
> revalidating?
OK, I'll give that a shot because I think it solves the issue as well.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
parent reply other threads:[~2019-08-30 18:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190830055435.GB8492@lst.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4fbecce-f647-71c2-45fc-00352734e4ca@grimberg.me \
--to=sagi@grimberg.me \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).