From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F08C282DD for ; Tue, 7 Jan 2020 22:28:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37C4D20715 for ; Tue, 7 Jan 2020 22:28:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nPk/1K/I"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="uYnmkDBt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37C4D20715 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KJnOeFUaTeBkWzZo+XuoEJyeo0iZUssl8mnSGYhYxKg=; b=nPk/1K/I9pFuvU Apv3dyRkP6RqWym1CwTBbtKJwHPtGm8mVYcjtpuFr6uHXdqltWEioLtDq4c2B7AJrqepTMqlYxwQv PxHhXR6KXHekoUVSPbCeGsIOX8z3Q1vqm3y/uhtv9F/MBwQRzVh+7cm5HC+4FQO63MapqxLDvLphM bvnT5BRQpRxSh1ssZUAS+H5Qawfxts8V6+lCkKIqWg3Y2NAd1JP2eyNC6EAUdk1bhV/ZjW6sh+RbF 7T3PFgQJeF+LQv3gmTfh2+FBsW8/dF9TThxAIb0lOXdlPikjKohg4r6MwxOoVbw4ggZSvQinwJbUJ Mpu5NvG/mIfytXr+e7rA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioxLB-00067G-5o; Tue, 07 Jan 2020 22:28:45 +0000 Received: from smtp-fw-9101.amazon.com ([207.171.184.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioxL8-00066F-UV for linux-nvme@lists.infradead.org; Tue, 07 Jan 2020 22:28:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1578436123; x=1609972123; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LRlH58C5d9znngWjy3uFjBYUUg3z1df7ROpFmuAf/5I=; b=uYnmkDBtl5nzFYPTso7HCUjroeOM5uAPtoQOjQgJsVKjtrqnZ46WJGFU Mu4a5L53Ew19+dvoPDzx7Pac38/aMSDstVOf/8YCMBY/mfyVT4n7cXuEq BQjhoiaxdnCHwwECR/3OVvS/qw++ZWXvjfd1iqCiCB0v90OoOcUUKDWKK A=; IronPort-SDR: AuEZdKRYI4+iXdoh0i3w2sfARMEul7xPeRcjEbLLek8onVu1cfXFFoT3v42WGaiCke9l94gYS5 IjN8tJYTPPEA== X-IronPort-AV: E=Sophos;i="5.69,407,1571702400"; d="scan'208";a="8909129" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-69849ee2.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 07 Jan 2020 22:28:31 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2a-69849ee2.us-west-2.amazon.com (Postfix) with ESMTPS id 88523A2269; Tue, 7 Jan 2020 22:28:30 +0000 (UTC) Received: from EX13D11UWB002.ant.amazon.com (10.43.161.20) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 7 Jan 2020 22:28:29 +0000 Received: from EX13D01UWB002.ant.amazon.com (10.43.161.136) by EX13D11UWB002.ant.amazon.com (10.43.161.20) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 7 Jan 2020 22:28:29 +0000 Received: from EX13D01UWB002.ant.amazon.com ([10.43.161.136]) by EX13d01UWB002.ant.amazon.com ([10.43.161.136]) with mapi id 15.00.1367.000; Tue, 7 Jan 2020 22:28:29 +0000 From: "Singh, Balbir" To: "martin.petersen@oracle.com" Subject: Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity Thread-Topic: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity Thread-Index: AQHVxQ2ElvRRrRbcTUG70jpk0aWGbqffyXeA Date: Tue, 7 Jan 2020 22:28:29 +0000 Message-ID: References: <20200102075315.22652-1-sblbir@amazon.com> <20200102075315.22652-6-sblbir@amazon.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.160.109] Content-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200107_142843_023930_28D42AE6 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "axboe@kernel.dk" , "Chaitanya.Kulkarni@wdc.com" , "mst@redhat.com" , "jejb@linux.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "Sangaraju, Someswarudu" , "hch@lst.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, 2020-01-06 at 22:48 -0500, Martin K. Petersen wrote: > Balbir, > > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > > index 5afb0046b12a..1a3be30b6b78 100644 > > --- a/drivers/scsi/sd.c > > +++ b/drivers/scsi/sd.c > > @@ -3184,7 +3184,7 @@ static int sd_revalidate_disk(struct gendisk *disk) > > > > sdkp->first_scan = 0; > > > > - set_capacity(disk, logical_to_sectors(sdp, sdkp->capacity)); > > + disk_set_capacity(disk, logical_to_sectors(sdp, sdkp->capacity)); > > sd_config_write_same(sdkp); > > kfree(buffer); > > We already emit an SDEV_EVT_CAPACITY_CHANGE_REPORTED event if device > capacity changes. However, this event does not automatically cause > revalidation. > The proposed idea is to not reinforce revalidation, unless explictly specified (in the thread before Bob Liu had suggestions). The goal is to notify user space of changes via RESIZE. SCSI sd can opt out of this IOW, I can remove this if you feel SDEV_EVT_CAPACITY_CHANGE_REPORTED is sufficient for current use cases. Balbir Singh. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme