From: Sagi Grimberg <sagi@grimberg.me>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Omar Sandoval <osandov@osandov.com>
Cc: Keith Busch <kbusch@kernel.org>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 5/7] nvme: support nvme-tcp when runinng tests
Date: Fri, 7 Aug 2020 16:46:24 -0700 [thread overview]
Message-ID: <bd794263-02d2-a723-44de-3a9f63723275@grimberg.me> (raw)
In-Reply-To: <BYAPR04MB496517FF9B9E262ACD555A2686490@BYAPR04MB4965.namprd04.prod.outlook.com>
>> + tcp)
>> + _have_modules nvmet nvme-core nvme-tcp nvmet-tcp
>> + _have_configfs
>> + ;;
>>
> Same as previous nvme-core nvmet configfs can use a helper.
So for every trtype instead of having:
_have_modules nvmet nvme-core <trtype specific>
_have_configfs
You will have:
_have_nvme_fabrics_common
_have_modules <trtype specific>
Don't see it as an improvement...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-07 23:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 19:15 [PATCH v2 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 1/7] nvme: consolidate nvme requirements based on transport type Sagi Grimberg
2020-08-07 2:41 ` Chaitanya Kulkarni
2020-08-07 17:14 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 2/7] nvme: consolidate some nvme-cli utility functions Sagi Grimberg
2020-08-07 2:53 ` Chaitanya Kulkarni
2020-08-07 17:15 ` Sagi Grimberg
2020-08-08 1:47 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 3/7] nvme: make tests transport type agnostic Sagi Grimberg
2020-08-07 3:09 ` Chaitanya Kulkarni
2020-08-07 17:19 ` Sagi Grimberg
2020-08-10 17:35 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 4/7] tests/nvme: restrict tests to specific transports Sagi Grimberg
2020-08-07 3:15 ` Chaitanya Kulkarni
2020-08-07 17:21 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 5/7] nvme: support nvme-tcp when runinng tests Sagi Grimberg
2020-08-07 3:16 ` Chaitanya Kulkarni
2020-08-07 23:46 ` Sagi Grimberg [this message]
2020-08-08 1:49 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 6/7] common/multipath-over-rdma: don't retry module unload Sagi Grimberg
2020-08-07 3:18 ` Chaitanya Kulkarni
2020-08-07 14:03 ` Bart Van Assche
2020-08-07 17:23 ` Sagi Grimberg
2020-08-07 17:34 ` Bart Van Assche
2020-08-07 17:50 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 7/7] nvme: support rdma transport type Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd794263-02d2-a723-44de-3a9f63723275@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).