From: James Smart <james.smart@broadcom.com>
To: Mark Ruijter <MRuijter@onestopsystems.com>,
Sagi Grimberg <sagi@grimberg.me>
Cc: Max Gurtovoy <maxg@mellanox.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH] nvmet: make ctrl-id configurable
Date: Tue, 12 Nov 2019 16:44:14 -0800 [thread overview]
Message-ID: <ccb5809a-e34e-ae69-4659-4b420d1e8c8d@broadcom.com> (raw)
In-Reply-To: <81646D07-6C44-427C-B959-F87F7F1B57AC@onestopsystems.com>
On 11/12/2019 1:19 PM, Mark Ruijter wrote:
>>> I think we need a cntlid_max.
> I initially thought about that and decided it was not worth it. When a user selects the minimum it is highly unlikely that a collision will occur.
why would you leave that to chance ?
>
> With a symmetrical configuration even an offset of 1 would be enough to prevent that?
ahh.. it seems you are answering with your specific solution in sight. I
think we would want it be more generic in scope.
>
> I don’t mind adding it if the consensus is that it’s worth the effort.
>
> Mark
>
I second the cntlid_max add.
-- james
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-13 0:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 18:13 [PATCH] nvmet: make ctrl-id configurable Chaitanya Kulkarni
2019-11-03 18:15 ` Chaitanya Kulkarni
2019-11-04 9:36 ` Max Gurtovoy
2019-11-04 10:45 ` Mark Ruijter
2019-11-04 14:04 ` Max Gurtovoy
2019-11-04 16:36 ` Mark Ruijter
2019-11-05 22:38 ` James Smart
2019-11-06 16:51 ` Sagi Grimberg
2019-11-08 16:15 ` Mark Ruijter
2019-11-12 19:01 ` Sagi Grimberg
2019-11-12 21:19 ` Mark Ruijter
2019-11-13 0:44 ` James Smart [this message]
2019-11-13 23:40 ` Chaitanya Kulkarni
2019-11-14 15:55 ` Mark Ruijter
2019-11-20 18:51 ` Christoph Hellwig
2019-11-05 21:15 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccb5809a-e34e-ae69-4659-4b420d1e8c8d@broadcom.com \
--to=james.smart@broadcom.com \
--cc=MRuijter@onestopsystems.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).