From: Sagi Grimberg <sagi@grimberg.me>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Logan Gunthorpe <logang@deltatee.com>,
Keith Busch <kbusch@kernel.org>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 1/2] nvmet: fix oops in nvmet_execute_passthru_cmd()
Date: Thu, 6 Aug 2020 12:41:01 -0700 [thread overview]
Message-ID: <d09e3ca6-4589-25a2-6b54-10a3b076ccfe@grimberg.me> (raw)
In-Reply-To: <BYAPR04MB49659642F181754E06FF02DC86480@BYAPR04MB4965.namprd04.prod.outlook.com>
>> I don't think this is quite accurate either. It looks to me like it's
>> just a bug in the error path logic. If the namespace is invalid, it
>> doesn't even try to allocate the request so it should really just order
>> the cleanup correctly and skip it, if it's not allocated.
>>
>> I think a fix like this would be cleaner:
>>
>
> Christoph, Sagi how guys would like to have this fix?
>
> I personally like to avoid introducing new labels unless they are
> extremely necessary.
I think that having an explicit and reverse-ordered target error labels
are always better.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-06 19:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 7:31 [PATCH 0/2] nvmet: couple of passthru fixes Chaitanya Kulkarni
2020-08-06 7:31 ` [PATCH 1/2] nvmet: fix oops in nvmet_execute_passthru_cmd() Chaitanya Kulkarni
2020-08-06 15:42 ` Keith Busch
2020-08-06 16:12 ` Logan Gunthorpe
2020-08-06 16:26 ` Keith Busch
2020-08-06 19:40 ` Chaitanya Kulkarni
2020-08-06 19:45 ` Logan Gunthorpe
2020-08-06 19:54 ` Sagi Grimberg
2020-08-06 19:55 ` Logan Gunthorpe
2020-08-06 19:57 ` Chaitanya Kulkarni
2020-08-06 20:03 ` Sagi Grimberg
2020-08-06 20:06 ` Chaitanya Kulkarni
2020-08-06 19:55 ` Chaitanya Kulkarni
2020-08-06 19:18 ` Sagi Grimberg
2020-08-06 19:31 ` Chaitanya Kulkarni
2020-08-06 19:41 ` Sagi Grimberg [this message]
2020-08-06 19:44 ` Chaitanya Kulkarni
2020-08-06 19:29 ` Chaitanya Kulkarni
2020-08-06 7:31 ` [PATCH 2/2] nvmet: call blk_mq_free_request() directly Chaitanya Kulkarni
2020-08-06 15:45 ` Keith Busch
2020-08-06 16:14 ` Logan Gunthorpe
2020-08-06 19:19 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d09e3ca6-4589-25a2-6b54-10a3b076ccfe@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).