From: Sagi Grimberg <sagi@grimberg.me>
To: "Grupi, Elad" <Elad.Grupi@dell.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH] nvmet-tcp: Fix receive data digest calculation for multiple h2cdata PDUs
Date: Mon, 15 Mar 2021 23:29:42 -0700 [thread overview]
Message-ID: <d15f0cd8-e780-80bb-ad65-a9963ca09100@grimberg.me> (raw)
In-Reply-To: <DM6PR19MB40112D4524285D2D496F2186EF829@DM6PR19MB4011.namprd19.prod.outlook.com>
> Hi Sagi,
Hey Elad,
> Can you please explain why you avoid calling nvmet_tcp_unmap_pdu_iovec on data_digest PDU?
> I don't recall any other case that unmap is being called on good path.
You are correct. We need to either add unmap in the data_digest path
here or when completing the data digest reception.. Probably better
here.
Care to send a patch or should I?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-16 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 23:00 [PATCH] nvmet-tcp: Fix receive data digest calculation for multiple h2cdata PDUs Sagi Grimberg
2021-02-07 16:16 ` Christoph Hellwig
2021-02-21 19:37 ` Grupi, Elad
2021-03-16 6:29 ` Sagi Grimberg [this message]
2021-03-16 15:24 ` Grupi, Elad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d15f0cd8-e780-80bb-ad65-a9963ca09100@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Elad.Grupi@dell.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).