From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D775EC43331 for ; Fri, 6 Sep 2019 18:08:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A71FA20838 for ; Fri, 6 Sep 2019 18:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r6KD3e9V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A71FA20838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ckpZntZKnIovDzoVuKOdDJizFUO7JBQpuRv3ACuJjuE=; b=r6KD3e9VhrZmf0W5oygRmF45e l7MMjarvWV0Z+ZNEcWny6ym8D4rrll90LyIVL3Kz8DApDhspluaQhHivih/on7H9BxdclUtpmA20I mlSRuzBnOi12BBdA0qNBa4CI5hYOy6HP4cdS04PteqDjnUfSJAiBvTmvnszO0TIlEH8eeFU99tzbF EQblubSREIGO1a3OXYSF39nCy4kpHG5Jq+OrsyaffcQdbyexL6egrKKh0OeRaIRcUWyFylLlnNeZb DwUzyERscx6AXqY4oNiE8dPd857pOJ7BCcXxTyzoMhmMpUnsrkIuW/gcaJ/Ix3PX5SkqxxwrRoZ9B 7kPjJ/Mgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6IeR-000849-Ki; Fri, 06 Sep 2019 18:08:03 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i6IeO-00083f-8x for linux-nvme@lists.infradead.org; Fri, 06 Sep 2019 18:08:01 +0000 Received: by mail-ot1-f66.google.com with SMTP id n7so6532620otk.6 for ; Fri, 06 Sep 2019 11:07:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kJc8FkLgbQPVQ4tFTiwrpMw8Px0ljhZ7sdsqeuO6v7c=; b=TskV9xP/ghwiYwe/A5oFILet+n+uRoN7rEEDiBg7g6XjV0E5Rcm6OlRcAC7iaIE9nV 6qICb8ZhPrr0IyZU8ABt+Y4N5Ja44Y7HN82/lUZFXP3xbsDdemZsixcSVQV+CLazj0Rt kTDm/BiogWuvSOomFdldtsJdYPlB27dc205XVOcWm6uOEb4J4ArGCPMQoX6pbhpO1hOk +Y+vbDFpU12H0K6qinFLKYANtUD97YNTrDPp8CHtFDacQAAmKxNVBPC6M9QosADAGV7e IcHZyDHa/CdRzvCleu/hVbJZwWGCqIyz6Txwck/dzrPs3MrdGcRfkbs3wUd4SJmwskAE HQjQ== X-Gm-Message-State: APjAAAUGt5i5IywcduGQ/n7Re7aaijoOot5EhNhNQZ4Nt+xb9qUvD78L 2cjb/wf5ZrC7mhKU7SV0t8Q= X-Google-Smtp-Source: APXvYqyrQU02EBEuKRU24KFGCaGhz4tSPfi4yCEpxpFWRMBTjJDU8bSXbPvym+ea9VaDlvebr2rpaA== X-Received: by 2002:a9d:2f09:: with SMTP id h9mr8325700otb.21.1567793277469; Fri, 06 Sep 2019 11:07:57 -0700 (PDT) Received: from ?IPv6:2600:1700:65a0:78e0:514:7862:1503:8e4d? ([2600:1700:65a0:78e0:514:7862:1503:8e4d]) by smtp.gmail.com with ESMTPSA id a2sm2019981oiy.29.2019.09.06.11.07.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Sep 2019 11:07:56 -0700 (PDT) Subject: Re: [PATCH v4 3/4] nvme: add uevent variables for controller devices To: Christoph Hellwig References: <20190904215954.15423-1-sagi@grimberg.me> <20190904215954.15423-4-sagi@grimberg.me> <20190906125953.GA8873@lst.de> From: Sagi Grimberg Message-ID: Date: Fri, 6 Sep 2019 11:07:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906125953.GA8873@lst.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_110800_319191_D1C8621E X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Hannes Reinecke , linux-nvme@lists.infradead.org, James Smart Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org >> +static int nvme_class_uevent(struct device *d, struct kobj_uevent_env *env) >> +{ >> + struct nvme_ctrl *ctrl = >> + container_of(d, struct nvme_ctrl, ctrl_device); > > Why the weird variable name of d instead of dev? as we usually use? copy and paste from netdev_uevent :) >> + if (opts) { > > if (!opts) > return; > > ? But then again how we can end up here without ctrl->opts? pci controllers. >> + ret = add_uevent_var(env, "NVME_TRSVCID=%s", >> + (opts && opts->trsvcid) ? opts->trsvcid : "none"); > > No need to check opts here again. Will fix > >> + ret = add_uevent_var(env, "NVME_HOST_TRADDR=%s", >> + (opts && opts->host_traddr) ? opts->host_traddr : "none"); > > Same here. Will fix _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme