From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9619CC4360C for ; Fri, 27 Sep 2019 22:34:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6675A21655 for ; Fri, 27 Sep 2019 22:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yx/4CTie" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6675A21655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TTuK8iUMhnQKZ2o4D9eHJBFwQ9An8taqn3RsoPAnnWo=; b=Yx/4CTiep/8aWv/6TGY+9avto RwXu+PuQejB3ApqSh2rnVvMUZECbi6pakP5YkyoGlq3Z7auFoGa3ksfWskf3W6qwm8xsz7G1CsdBG yqBm8cB6fd+Hz7CkqOH0LKIw7IXnTmDCQA7UdS/w9g2IKHdt7pNKDMurzUXuFdhVGpc3iGnUZWKDQ jzwtCnjyWrE5498Df+cBusAG7MZVHsDpyEm+cMYSOe6HkE+BBKdknIoeVjio10VjmyHKjMhIDOQ+j hfh7uObBWelth4fYsGAnz72+bmL/LcRyP+U8q1F+zf3PEfHa4tavdYNgC8ud8T1TrHS+mtr/WXBqI VlHCTTa+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDyor-000742-If; Fri, 27 Sep 2019 22:34:33 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDyoo-00073e-R5 for linux-nvme@lists.infradead.org; Fri, 27 Sep 2019 22:34:32 +0000 Received: by mail-oi1-f195.google.com with SMTP id k25so6498306oiw.13 for ; Fri, 27 Sep 2019 15:34:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QqOL/HYipstsdzRdbKFa7B6VDhApW8sIYh5FSgaWqLk=; b=oSfEAb1D9DaBA4Tz3UzJrjgqbv5aBRUbqt2bcrDuIuDgwZwh9I1OTHtnwGH03rOCJt uf/EdciNoRUS6dODOQxMrM06Vub/HDh62dVZlLU7LTKZwZkEvoW18zbaBH5n7WEoxlSN SwzxP0xYitHScyYwMD0wyp1mZu/HveGMSrabNbkTHYO9oIO1ucxhqtJ01ydPOXvI6KPc xZA8N0P6eh8Pf3yj+E6Ae2Olg2sqX2WG2XU2hOWYQv8BRZj+3sZyDgRrtRzuHJMpOYt6 32ykaUTqGVPlrEUNT05l787UqJbMZD4zbw0+99zFRBpCUuQFTeO2asTGwkmWCuPoeW3M xlYw== X-Gm-Message-State: APjAAAVSo9ggEAAoQBZJ5e2Ib55nqMW8bvpJ+rSIoX2bJdzqV0zNapoc uuahQOZ544brBJ7ghioLB5rlpiR1 X-Google-Smtp-Source: APXvYqwoUQzpFRVGmAgfJYzaAqSjx4815SxHBMPEiBbLbJnw0mpfnB8Unm8kWOTpcluvIrXss9+pEQ== X-Received: by 2002:aca:3c82:: with SMTP id j124mr9151159oia.82.1569623667038; Fri, 27 Sep 2019 15:34:27 -0700 (PDT) Received: from ?IPv6:2600:1700:65a0:78e0:514:7862:1503:8e4d? ([2600:1700:65a0:78e0:514:7862:1503:8e4d]) by smtp.gmail.com with ESMTPSA id 88sm1489394otb.63.2019.09.27.15.34.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Sep 2019 15:34:26 -0700 (PDT) Subject: Re: [PATCH] nvmet: add revalidate ns sysfs attribute to handle device resize To: Christoph Hellwig References: <20190926231940.7494-1-m.malygin@yadro.com> <80c2509b-bd48-c3c4-13bf-8ad6b1c0f77a@grimberg.me> <20190927221352.GA17568@lst.de> From: Sagi Grimberg Message-ID: Date: Fri, 27 Sep 2019 15:34:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190927221352.GA17568@lst.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190927_153430_876482_F1B80F35 X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mikhail Malygin , linux-nvme@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org >>> +int nvmet_ns_revalidate(struct nvmet_ns *ns) >>> +{ >>> + struct nvmet_subsys *subsys = ns->subsys; >>> + int ret = 0; >>> + >>> + mutex_lock(&subsys->lock); >>> + if(!ns->enabled){ >>> + goto out_unlock; >>> + } >>> + >>> + if(ns->bdev){ >>> + ret = nvmet_bdev_ns_revalidate(ns); >>> + }else if(ns->file){ >>> + ret = nvmet_file_ns_revalidate(ns); >>> + } >>> + >>> + nvmet_ns_changed(subsys, ns->nsid); >> >> Shouldn't that happen only of the size changed? > > s/of/if/ ? Yes.. > I guess we could do a sanity check first. > >> So what is the model here? have some udev rule to >> trigger this? > > Well, even if there was a udev rule we can't directly rely on it. What do you mean we can't rely on it? I do understand that we'd have no triggers for file-backed namespaces. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme