From: James Smart <james.smart@broadcom.com>
To: James Smart <jsmart2021@gmail.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-cli: Fix systemd service script use of CONNECT_ARGS env var
Date: Mon, 6 Jan 2020 11:22:49 -0800 [thread overview]
Message-ID: <daffcde4-256f-807c-9099-53a1196ab197@broadcom.com> (raw)
In-Reply-To: <20191219190534.11673-1-jsmart2021@gmail.com>
ping...
On 12/19/2019 11:05 AM, James Smart wrote:
> In testing, some environments are not properly expanding CONNECT_ARGS.
>
> Change systemd service file use of CONNECT_ARGS to be encapsulated by
> apostrophes and parens.
>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
> nvmf-autoconnect/systemd/nvmf-connect@.service | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nvmf-autoconnect/systemd/nvmf-connect@.service b/nvmf-autoconnect/systemd/nvmf-connect@.service
> index 10fb3aa..c60f146 100644
> --- a/nvmf-autoconnect/systemd/nvmf-connect@.service
> +++ b/nvmf-autoconnect/systemd/nvmf-connect@.service
> @@ -11,4 +11,4 @@ Requires=nvmf-connect.target
> [Service]
> Type=simple
> Environment="CONNECT_ARGS=%i"
> -ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e $CONNECT_ARGS`"
> +ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e '${CONNECT_ARGS}'`"
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-01-06 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 19:05 [PATCH] nvme-cli: Fix systemd service script use of CONNECT_ARGS env var James Smart
2020-01-06 19:22 ` James Smart [this message]
2020-01-07 17:04 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daffcde4-256f-807c-9099-53a1196ab197@broadcom.com \
--to=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).