From: Logan Gunthorpe <logang@deltatee.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2 1/2] nvmet-passthru: Limit mdts by BIO_MAX_PAGES
Date: Mon, 19 Oct 2020 20:05:36 -0600 [thread overview]
Message-ID: <efa5f46a-cb8f-11c5-1faf-c9a4cf3e0792@deltatee.com> (raw)
In-Reply-To: <BYAPR04MB4965B1360F5F6A1D13FF1DD0861F0@BYAPR04MB4965.namprd04.prod.outlook.com>
On 2020-10-19 8:03 p.m., Chaitanya Kulkarni wrote:
> On 10/19/20 08:40, Logan Gunthorpe wrote:
>>>> + max_hw_sectors = min_not_zero(BIO_MAX_PAGES << (PAGE_SHIFT - 9),
>>>> + max_hw_sectors);
>>> can 9 be replaced with SECTOR_SHIFT ?
>> Oh, yes, that does sound better. Thanks.
>>
>> Logan
>>
>>
> Although it is a good suggestion we are not using the SECTOR_SIZE in
>
> the target code, I don't think we should change that for passthru. Also,
>
> I remember that on the block layer mailing list SECTOR_SIZE macro been
>
> discouraged over use of 9.
Well in that case v2 or v3 can be merged depending on maintainer preference.
Logan
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-10-20 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 22:19 [PATCH v2 1/2] nvmet-passthru: Limit mdts by BIO_MAX_PAGES Logan Gunthorpe
2020-10-16 22:19 ` [PATCH v2 2/2] nvmet-passthru: Cleanup nvmet_passthru_map_sg() Logan Gunthorpe
2020-10-19 11:20 ` [PATCH v2 1/2] nvmet-passthru: Limit mdts by BIO_MAX_PAGES Max Gurtovoy
2020-10-19 15:40 ` Logan Gunthorpe
[not found] ` <BYAPR04MB4965B1360F5F6A1D13FF1DD0861F0@BYAPR04MB4965.namprd04.prod.outlook.com>
2020-10-20 2:05 ` Logan Gunthorpe [this message]
2020-10-22 13:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efa5f46a-cb8f-11c5-1faf-c9a4cf3e0792@deltatee.com \
--to=logang@deltatee.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).