From: Martin Wilck <mwilck@suse.com>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Martin George <marting@netapp.com>
Cc: Hannes Reinecke <hare@suse.de>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvme: multipath: round-robin: fix single non-optimized path case
Date: Thu, 06 Aug 2020 21:40:55 +0200 [thread overview]
Message-ID: <f00f506389acbe919016f8f4dc9ac6d91442af0c.camel@suse.com> (raw)
In-Reply-To: <20200806131932.20017-2-mwilck@suse.com>
On Thu, 2020-08-06 at 15:19 +0200, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> If there's only one usable, non-optimized path,
> nvme_round_robin_path()
> returns NULL, which is wrong. Fix it by falling back to "old", like
> in
> the single optimized path case. Also, if the active path isn't
> changed,
> there's no need to re-assign the pointer.
>
> Fixes: 3f6e3246db0e ("nvme-multipath: fix logic for non-optimized
> paths")
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> Reported-by: Martin George <marting@netapp.com>
I made a mistake here. It should be
Signed-off-by: Martin George <marting@netapp.com>
because Martin G. provided the initial idea for the fix.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-06 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:19 [PATCH 0/2] nvme: multipath: round-robin fixes mwilck
2020-08-06 13:19 ` [PATCH 1/2] nvme: multipath: round-robin: fix single non-optimized path case mwilck
2020-08-06 19:40 ` Martin Wilck [this message]
2020-08-07 7:36 ` George, Martin
2020-08-06 13:19 ` [PATCH 2/2] nvme: multipath: round-robin: eliminate "fallback" variable mwilck
2020-08-06 19:16 ` [PATCH 0/2] nvme: multipath: round-robin fixes Sagi Grimberg
2020-08-06 20:16 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f00f506389acbe919016f8f4dc9ac6d91442af0c.camel@suse.com \
--to=mwilck@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).