From: Dongli Zhang <dongli.zhang@oracle.com>
To: James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, hch@lst.de
Cc: sagi@grimberg.me, chaitanya.kulkarni@wdc.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format
Date: Wed, 10 Jun 2020 07:53:33 -0700 [thread overview]
Message-ID: <f93adee4-ebf0-a229-e507-4ef4e4fe812d@oracle.com> (raw)
In-Reply-To: <60df6752-3512-f7a9-b0df-1096b93b8eda@broadcom.com>
Hi Christoph,
Would you mind apply this one with the Reviewed-by from James and Sagi?
https://lore.kernel.org/linux-nvme/60df6752-3512-f7a9-b0df-1096b93b8eda@broadcom.com/
https://lore.kernel.org/linux-nvme/c4ec2d9e-b08c-19b2-16a5-93520ca13c2e@grimberg.me/
Thank you very much!
Dongli Zhang
On 6/4/20 8:20 AM, James Smart wrote:
> On 5/25/2020 9:21 PM, Dongli Zhang wrote:
>> The nvme host and target verify the wwnn and wwpn format via
>> nvme_fc_parse_traddr(). For instance, it is required that the length of
>> wwnn to be either 21 ("nn-0x") or 19 (nn-).
>>
>> Add this verification to nvme-fcloop so that the input should always be in
>> hex and the length of input should always be 18.
>>
>> Otherwise, the user may use e.g. 0x2 to create fcloop local port, while
>> 0x0000000000000002 is required for nvme host and target. This makes the
>> requirement of format confusing.
>>
>> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
>> ---
>> drivers/nvme/target/fcloop.c | 29 +++++++++++++++++++++++------
>> 1 file changed, 23 insertions(+), 6 deletions(-)
>>
>>
>
> Reviewed-by: James Smart <james.smart@broadcom.com>
>
> Looks good. Sorry for the delay.
>
> -- james
>
>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-06-10 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 4:21 [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format Dongli Zhang
2020-06-04 6:43 ` Dongli Zhang
2020-06-04 6:54 ` Chaitanya Kulkarni
2020-06-04 14:03 ` Hannes Reinecke
2020-06-04 15:20 ` James Smart
2020-06-10 14:53 ` Dongli Zhang [this message]
2020-06-04 17:27 ` Sagi Grimberg
2020-06-17 8:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f93adee4-ebf0-a229-e507-4ef4e4fe812d@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).