From: Eduard Hasenleithner <eduard@hasenleithner.at>
To: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [RFC PATCH] Workaround for discard on non-conformant nvme devices
Date: Wed, 6 Nov 2019 21:22:00 +0100 [thread overview]
Message-ID: <f9e32847-00b1-59f5-8b15-860a94598e79@hasenleithner.at> (raw)
In-Reply-To: <20191106182339.GE29853@redsun51.ssa.fujisawa.hgst.com>
On 06.11.19 19:23, Keith Busch wrote:
>> This needs to come with a quirk for it.
>
> Yeah, and have the broken ones to use the ctrl->discard_page so that you
> don't need to worry about the alignment of the address kmalloc returns.
This raises some questions for me.
Why bother maintaining a quirk list and have additional complexity with
separate code paths?
Couldn't we just simply use the discard_page for all discards?
Are there even nvme devices out there which have conformant behavior in
this respect?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-06 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 21:47 [RFC PATCH] Workaround for discard on non-conformant nvme devices Eduard Hasenleithner
2019-11-06 16:52 ` Sagi Grimberg
2019-11-06 18:23 ` Keith Busch
2019-11-06 20:22 ` Eduard Hasenleithner [this message]
2019-11-06 20:43 ` Keith Busch
2019-11-06 21:10 ` Eduard Hasenleithner
2019-11-06 21:34 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e32847-00b1-59f5-8b15-860a94598e79@hasenleithner.at \
--to=eduard@hasenleithner.at \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).