From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BC1FA372C for ; Thu, 7 Nov 2019 02:37:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85AC42075C for ; Thu, 7 Nov 2019 02:37:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nVnvPTML"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SQkpWhlJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85AC42075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:From:Subject:To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zCmrzlxzJ+dmijyBccAGfB2CinJiZhxIZ27uP9tCLDE=; b=nVnvPTMLK5QTGJ jHtShfVu8MgsPOA0rwxsdm1gpjX4vXi/oVK//JYxVXOCD7GhBgRqoNt0T2hIA2VWo8QeRN7AbbEQ/ kJ+wZvzF8GhTNQNxkFxSsnsdregegNLpFt51Yfb/jCdeAL5Yx9+bYaoTypjdo3rz4nJ2dBxX21tcE alhPCnI+MVtwSW9okIpDiX25lntJaxrnx16EkRluCIXMeMrlMl3dD4U7HtevXLblrhKrn1VkpUrq7 Cov6bu4C259ZxRCvkzdOwDf8T1JGev9P1npShKAswEqz6ZghXV+e85q7MYKs39IKCWvM44QFtq0/v KwurA3soMpZL5VU+KrTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSXfR-0007XH-A2; Thu, 07 Nov 2019 02:37:01 +0000 Received: from userp2120.oracle.com ([156.151.31.85]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSXfO-0007Wf-4d for linux-nvme@lists.infradead.org; Thu, 07 Nov 2019 02:36:59 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA72YIqx006554; Thu, 7 Nov 2019 02:36:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=0uotxuHW25CUK0DzaYd2r2klUGBmzn4YKI41lli6p/o=; b=SQkpWhlJTkXo7hm2AU6Ngk5CYYA+X+fqMw6nXknOb/DsyDPCUPysymE7BWAH8OykPKuw Ar3aSniAYWtY9VBftRuEdJWOvDHLO4mSGA6KEQpPl8GxkyUF0e9VVfdrHFNlQd9KpoA2 VcmmkJnYjTwRFPrx24ZbME80ODsmAiXQR7fBTfcVi2vo5UBXBvatBhtOQDXDebNs/LGI PL59HKVqqfq8iayaSOOypMNgH7jONovYPbrgQ0uNY8ghwUt6hiBvGd6eanFhCfyM6wEr wTtjjL0dY3m6MQjCxZ1pKZBvlGioUT1ViKYXNCwmFbjvrEpkhZinDDLb9gIsVc7bBFP/ Og== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2w41w0twt1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Nov 2019 02:36:42 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA72Xffb014176; Thu, 7 Nov 2019 02:36:41 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2w41wfpq84-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Nov 2019 02:36:41 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xA72aeJh014274; Thu, 7 Nov 2019 02:36:40 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Nov 2019 18:36:40 -0800 To: Max Gurtovoy Subject: Re: [PATCH] nvme-cli/fabrics: Add pi_enable param to connect cmd From: "Martin K. Petersen" Organization: Oracle Corporation References: <20191105162026.183901-1-maxg@mellanox.com> <20191105162026.183901-2-maxg@mellanox.com> Date: Wed, 06 Nov 2019 21:36:37 -0500 In-Reply-To: <20191105162026.183901-2-maxg@mellanox.com> (Max Gurtovoy's message of "Tue, 5 Nov 2019 18:20:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=767 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911070025 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=849 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911070026 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_183658_315773_B6C1D095 X-CRM114-Status: GOOD ( 14.37 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, vladimirk@mellanox.com, shlomin@mellanox.com, israelr@mellanox.com, linux-nvme@lists.infradead.org, idanb@mellanox.com, oren@mellanox.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Max, > Added 'pi_enable' to 'connect' command so users can enable metadata > support. > > usage examples: > nvme connect --pi_enable --transport=rdma --traddr=10.0.1.1 --nqn=test-nvme > nvme connect -p -t rdma -a 10.0.1.1 -n test_nvme Why does it have to be explicitly enabled? I can understand why you'd want the capability to disable PI in case you encounter a bad target. But having to opt-in is different from how the rest of the block integrity code works. In SCSI, if HBA and target are capable, both DIX and PI enabled unless you explicitly disable them. -- Martin K. Petersen Oracle Linux Engineering _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme