From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11243C001DF for ; Fri, 28 Jul 2023 15:59:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236144AbjG1P7v (ORCPT ); Fri, 28 Jul 2023 11:59:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234529AbjG1P7u (ORCPT ); Fri, 28 Jul 2023 11:59:50 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAD9E110; Fri, 28 Jul 2023 08:59:48 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 42D155C00BE; Fri, 28 Jul 2023 11:59:45 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 28 Jul 2023 11:59:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1690559985; x=1690646385; bh=qe prRb5ewEtA801/sByp5QkC5fP6Mty2WClCI4vUDyY=; b=GQgIcy4Pj5IML3N/U+ muKPT/yi2mD0T9FSsMKqUPLjbTKA/2rj9ALRX8jCqneWSJM36GXeopCXKNSVXBzq Nu2zUEJCHDPQ2O2/yx0yWPHy4ikGSfMT3VXOZSCwEY46P/UNAjDSsac4bXlkHvNE MNXQ9hwmYVAHtkRmF7MiHR/rXa3HiG/KdOSusFIMeTClTXrrgaayaL4L0DO9izQm vJA7XKrN74xm4y2qXGDjrq06Rn7+OfRPYXIYyyk6eQxrhv9669kTMu0q74z37Pzf n6dVzAyANj4suvYmcNIys2HmTUeNl7EeZ4sI3JcxCnY3ZsP85mBEnWmSYaRNxIOI mGYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690559985; x=1690646385; bh=qeprRb5ewEtA8 01/sByp5QkC5fP6Mty2WClCI4vUDyY=; b=fqd+s0ENlYsKTRcjseNDnt5Za3Fxp r+wf+9KV/9zCpAPXpDD0r9bKp2LsJY8PGLgeHZ1crURsURghk4PFGfioDGq14SRX q0fcHkLQaHjvMqYpddp+xdbJlN7i1uUyC8FzigDrWahYAqVUD/b3Ej2aDDbPgfmz 1eYOfhZuRucmnbgNsReFyniIlwwvsBykugsbWzjeC+FO3bReIvZGR6Ypj/yLXUVa UHvyB4ebn5p5j8xRpUiKJ6EVEjZ31qNWW2Vu1skcH0eiqkhlNAx7clHh2bo+INlp +ZyP/PO+eRjJ1qUD1BPlpy91/kEYFfUUNPZcb45JcKe9Pey6v2ckoaTZA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id F3CC1B60089; Fri, 28 Jul 2023 11:59:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b Mime-Version: 1.0 Message-Id: <0808604b-a26e-43b8-83da-2c3dc12446d2@app.fastmail.com> In-Reply-To: <20230517154525.ljoamjlfhpejtizm@viti.kaiser.cx> References: <20230516153109.514251-1-arnd@kernel.org> <20230516153109.514251-6-arnd@kernel.org> <4e026f08-d733-4b01-ab47-e921d041e74e@app.fastmail.com> <20230517154525.ljoamjlfhpejtizm@viti.kaiser.cx> Date: Fri, 28 Jul 2023 17:59:20 +0200 From: "Arnd Bergmann" To: "Martin Kaiser" Cc: "Fabio Estevam" , "Arnd Bergmann" , soc@kernel.org, "Russell King" , "Bartosz Golaszewski" , "Hartley Sweeten" , "Alexander Sverdlin" , "Andre Przywara" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "NXP Linux Team" , "Vladimir Zapolskiy" , "Aaro Koskinen" , "Janusz Krzysztofik" , "Tony Lindgren" , "Andrew Lunn" , "Sebastian Hesselbarth" , "Gregory Clement" , "Daniel Mack" , "Haojian Zhuang" , "Robert Jarzmik" , "Viresh Kumar" , "Shiraz Hashim" , "Sudeep Holla" , "Lorenzo Pieralisi" , "Linus Walleij" , "Michael Turquette" , "Stephen Boyd" , "Greg Kroah-Hartman" , "Alan Stern" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-OMAP , linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision() Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, May 17, 2023, at 17:45, Martin Kaiser wrote: > Thus wrote Arnd Bergmann (arnd@arndb.de): > >> I think either way is ok to address the warning. If we wanted to do this >> properly, the mx{25,27,31,35,5}_revision functions could all be removed >> and the logic hooked up to imx_set_soc_revision() in the same way that >> they already use mxc_set_cpu_type() for drivers/soc/imx/soc-imx.c. > >> I'll leave it up to you, if you want to merge Martin's patches or >> a replacement for the soc-imx driver through the imx tree for 6.5, >> I'll drop my patch from this series, otherwise I'll keep it for now >> and we can still do it better at later point. > > I suggest we merge my patches for imx25 first and then clean up all the > older imx families to use the common functions. > > I've just rebased the patches against today's linux-next. My understanding > is that they have to go through the clk tree. This never happened, right? I see that mx25_revision() is still in the tree without any users, so I can't easily turn on the warning by default yet. Should I just go ahead and remove it for 5.6, or do you expect to have your patch ready in time for the merge window? Arnd