From: Liam Girdwood <lrg@slimlogic.co.uk>
To: dbrownell@users.sourceforge.net, Samuel Ortiz <sameo@openedhand.com>
Cc: Mark Brown <broonie@sirena.org.uk>,
OMAP <linux-omap@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] twl4030-regulator: expose VPLL2
Date: Mon, 16 Mar 2009 11:43:35 +0000 [thread overview]
Message-ID: <1237203815.6781.294.camel@vega.slimlogic.co.uk> (raw)
In-Reply-To: <200903131754.54997.david-b@pacbell.net>
On Fri, 2009-03-13 at 17:54 -0700, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Add VPLL2 to the set of twl4030-family regulators exposed for
> use by various drivers. It's commonly used to power the digital
> video outputs (e.g. LCD or DVI displays) on OMAP3 systems.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> Please apply to regulator-next and linux-omap ... I'll send
> some patches configuring various OMAP boards to use this.
>
> drivers/mfd/twl4030-core.c | 2 --
> drivers/regulator/twl4030-regulator.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -613,11 +613,9 @@ add_children(struct twl4030_platform_dat
>
> /* maybe add LDOs that are omitted on cost-reduced parts */
> if (twl_has_regulator() && !(features & TPS_SUBSET)) {
> - /*
> child = add_regulator(TWL4030_REG_VPLL2, pdata->vpll2);
> if (IS_ERR(child))
> return PTR_ERR(child);
> - */
>
> child = add_regulator(TWL4030_REG_VMMC2, pdata->vmmc2);
> if (IS_ERR(child))
> --- a/drivers/regulator/twl4030-regulator.c
> +++ b/drivers/regulator/twl4030-regulator.c
> @@ -404,8 +404,8 @@ static struct twlreg_info twl4030_regs[]
> TWL_ADJUSTABLE_LDO(VMMC2, 0x2b, 6),
> /*
> TWL_ADJUSTABLE_LDO(VPLL1, 0x2f, 7),
> - TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
> */
> + TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
> TWL_ADJUSTABLE_LDO(VSIM, 0x37, 9),
> TWL_ADJUSTABLE_LDO(VDAC, 0x3b, 10),
> /*
>
Samuel, I'm fine putting this through regulator if its fine with you ?
Thanks
Liam
next prev parent reply other threads:[~2009-03-16 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 0:54 [patch] twl4030-regulator: expose VPLL2 David Brownell
2009-03-16 11:43 ` Liam Girdwood [this message]
2009-03-16 15:51 ` Mark Brown
2009-03-19 18:13 ` Liam Girdwood
2009-03-22 19:19 ` Samuel Ortiz
2009-03-20 18:47 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237203815.6781.294.camel@vega.slimlogic.co.uk \
--to=lrg@slimlogic.co.uk \
--cc=broonie@sirena.org.uk \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).