linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Support Opensource <support.opensource@diasemi.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Milo Kim <milo.kim@ti.com>, Chanwoo Choi <cw00.choi@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 06/42] mfd: bcm2835: use PLATFORM_DEVID_NONE
Date: Tue, 22 Sep 2020 12:34:16 +0200	[thread overview]
Message-ID: <133be287646ff03e251b0a590b240fef650a0c19.camel@suse.de> (raw)
In-Reply-To: <20200921205016.20461-6-krzk@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

On Mon, 2020-09-21 at 22:49 +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

>  drivers/mfd/bcm2835-pm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c
> index 42fe67f1538e..a76014512bde 100644
> --- a/drivers/mfd/bcm2835-pm.c
> +++ b/drivers/mfd/bcm2835-pm.c
> @@ -44,7 +44,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
>  	if (IS_ERR(pm->base))
>  		return PTR_ERR(pm->base);
>  
> -	ret = devm_mfd_add_devices(dev, -1,
> +	ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
>  				   bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs),
>  				   NULL, 0, NULL);
>  	if (ret)
> @@ -60,7 +60,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev)
>  		if (IS_ERR(pm->asb))
>  			return PTR_ERR(pm->asb);
>  
> -		ret = devm_mfd_add_devices(dev, -1,
> +		ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
>  					   bcm2835_power_devs,
>  					   ARRAY_SIZE(bcm2835_power_devs),
>  					   NULL, 0, NULL);


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2020-09-22 10:34 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 20:49 [PATCH 01/42] mfd: arizona: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 02/42] mfd: as3711: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 03/42] mfd: as3722: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 04/42] mfd: atmel-hlcdc: " Krzysztof Kozlowski
2020-09-22  6:49   ` Alexandre Belloni
2020-09-21 20:49 ` [PATCH 05/42] mfd: axp20x: " Krzysztof Kozlowski
2020-09-22  8:21   ` Andy Shevchenko
2020-09-21 20:49 ` [PATCH 06/42] mfd: bcm2835: " Krzysztof Kozlowski
2020-09-21 21:12   ` Florian Fainelli
2020-09-22 10:34   ` Nicolas Saenz Julienne [this message]
2020-09-21 20:49 ` [PATCH 07/42] mfd: bcm590xx: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 08/42] mfd: da9055: " Krzysztof Kozlowski
2020-09-22  9:04   ` Adam Thomson
2020-09-21 20:49 ` [PATCH 09/42] mfd: da9150: " Krzysztof Kozlowski
2020-09-22  9:05   ` Adam Thomson
2020-09-21 20:49 ` [PATCH 10/42] mfd: intel_msic: " Krzysztof Kozlowski
2020-09-22  8:22   ` Andy Shevchenko
2020-09-21 20:49 ` [PATCH 11/42] mfd: intel_soc_pmic: " Krzysztof Kozlowski
2020-09-22  8:22   ` Andy Shevchenko
2020-09-21 20:49 ` [PATCH 12/42] mfd: kempld: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 13/42] mfd: lp8788: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 14/42] mfd: lp3943: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 15/42] mfd: max14577: " Krzysztof Kozlowski
2020-09-28  3:15   ` Chanwoo Choi
2020-09-21 20:49 ` [PATCH 16/42] mfd: max77686: " Krzysztof Kozlowski
2020-09-28  3:16   ` Chanwoo Choi
2020-09-21 20:49 ` [PATCH 17/42] mfd: max77693: " Krzysztof Kozlowski
2020-09-28  3:16   ` Chanwoo Choi
2020-09-21 20:49 ` [PATCH 18/42] mfd: max77843: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 19/42] mfd: max8907: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 20/42] mfd: max8997: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 21/42] mfd: max8998: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 22/42] mfd: mc13xxx: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 23/42] mfd: rc5t583: " Krzysztof Kozlowski
2020-09-21 20:49 ` [PATCH 24/42] mfd: rdc321x: " Krzysztof Kozlowski
2020-09-21 21:12   ` Florian Fainelli
2020-09-21 20:49 ` [PATCH 25/42] mfd: retu: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 26/42] mfd: rt5033: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 27/42] mfd: sec: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 28/42] mfd: sky81452: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 29/42] mfd: sta2x11: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 30/42] mfd: tc3589x: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 31/42] mfd: timberdale: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 32/42] mfd: tps6507x: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 33/42] mfd: tps65090: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 34/42] mfd: tps65217: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 35/42] mfd: tps6586x: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 36/42] mfd: tps65910: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 37/42] mfd: tps80031: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 38/42] mfd: twl6040: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 39/42] mfd: vx855: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 40/42] mfd: wl1273: " Krzysztof Kozlowski
2020-09-21 20:50 ` [PATCH 41/42] mfd: wm8400: " Krzysztof Kozlowski
2020-09-22  8:48   ` Charles Keepax
2020-09-21 20:50 ` [PATCH 42/42] mfd: wm8994: " Krzysztof Kozlowski
2020-09-22  8:48   ` Charles Keepax
2020-09-22  8:48 ` [PATCH 01/42] mfd: arizona: " Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=133be287646ff03e251b0a590b240fef650a0c19.camel@suse.de \
    --to=nsaenzjulienne@suse.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cw00.choi@samsung.com \
    --cc=f.fainelli@gmail.com \
    --cc=krzk@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=milo.kim@ti.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=patches@opensource.cirrus.com \
    --cc=rjui@broadcom.com \
    --cc=sbkim73@samsung.com \
    --cc=sbranden@broadcom.com \
    --cc=support.opensource@diasemi.com \
    --cc=tony@atomide.com \
    --cc=wens@csie.org \
    --subject='Re: [PATCH 06/42] mfd: bcm2835: use PLATFORM_DEVID_NONE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox