From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Vladimir Oltean <olteanv@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
Vadym Kochan <vkochan@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
Ivan Vecera <ivecera@redhat.com>, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-omap@vger.kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH resend net-next 2/2] net: bridge: switchdev: include local flag in FDB notifications
Date: Fri, 16 Apr 2021 13:11:19 +0300 [thread overview]
Message-ID: <1aadef14-f89e-ab08-84aa-a027425d26c0@ti.com> (raw)
In-Reply-To: <20210414165256.1837753-3-olteanv@gmail.com>
On 14/04/2021 19:52, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> As explained in bugfix commit 6ab4c3117aec ("net: bridge: don't notify
> switchdev for local FDB addresses") as well as in this discussion:
> https://lore.kernel.org/netdev/20210117193009.io3nungdwuzmo5f7@skbuf/
>
> the switchdev notifiers for FDB entries managed to have a zero-day bug,
> which was that drivers would not know what to do with local FDB entries,
> because they were not told that they are local. The bug fix was to
> simply not notify them of those addresses.
>
> Let us now add the 'is_local' bit to bridge FDB entries, and make all
> drivers ignore these entries by their own choice.
>
> Co-developed-by: Tobias Waldekranz <tobias@waldekranz.com>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 4 ++--
> drivers/net/ethernet/marvell/prestera/prestera_switchdev.c | 2 +-
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 5 +++--
> drivers/net/ethernet/rocker/rocker_main.c | 4 ++--
> drivers/net/ethernet/ti/am65-cpsw-switchdev.c | 4 ++--
> drivers/net/ethernet/ti/cpsw_switchdev.c | 4 ++--
> include/net/switchdev.h | 1 +
> net/bridge/br_switchdev.c | 3 +--
> net/dsa/slave.c | 2 +-
> 9 files changed, 15 insertions(+), 14 deletions(-)
For cpsw:
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Thank you.
--
Best regards,
grygorii
next prev parent reply other threads:[~2021-04-16 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 16:52 [PATCH resend net-next 0/2] Pass the BR_FDB_LOCAL information to switchdev drivers Vladimir Oltean
2021-04-14 16:52 ` [PATCH resend net-next 1/2] net: bridge: switchdev: refactor br_switchdev_fdb_notify Vladimir Oltean
2021-04-16 15:19 ` Ido Schimmel
2021-04-19 8:50 ` Nikolay Aleksandrov
2021-04-14 16:52 ` [PATCH resend net-next 2/2] net: bridge: switchdev: include local flag in FDB notifications Vladimir Oltean
2021-04-16 10:11 ` Grygorii Strashko [this message]
2021-04-16 15:22 ` Ido Schimmel
2021-04-16 17:33 ` Vladimir Oltean
2021-04-19 8:51 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aadef14-f89e-ab08-84aa-a027425d26c0@ti.com \
--to=grygorii.strashko@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=ioana.ciornei@nxp.com \
--cc=ivecera@redhat.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=tobias@waldekranz.com \
--cc=vigneshr@ti.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).