From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E787C433B4 for ; Fri, 16 Apr 2021 10:11:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F11B961107 for ; Fri, 16 Apr 2021 10:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238690AbhDPKMG (ORCPT ); Fri, 16 Apr 2021 06:12:06 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:35422 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235372AbhDPKMG (ORCPT ); Fri, 16 Apr 2021 06:12:06 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13GABPdm080049; Fri, 16 Apr 2021 05:11:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1618567885; bh=Tv2LpEewNe2bQ7IX9JcrH/n0K/2mfKwFDjxPXCP0Ki0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=lkpyKTuUp7FXpEvjs+ivEUGlDCWfn6rN8oobRHUirRdWx2e4ULg9+/mIl6TpZtJ+l d2P9NEG4LXENUUdya4mP+Rdct4X7cAeTcosEriE31t/i9++gXy67AzjCdn59hg7aLq DisfxLJ36cen2V1hCGRpKfkwq8k9XH8CjKFD7kL8= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13GABPwS116880 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 16 Apr 2021 05:11:25 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 16 Apr 2021 05:11:25 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Fri, 16 Apr 2021 05:11:25 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13GABKDU048542; Fri, 16 Apr 2021 05:11:21 -0500 Subject: Re: [PATCH resend net-next 2/2] net: bridge: switchdev: include local flag in FDB notifications To: Vladimir Oltean , Jakub Kicinski , "David S. Miller" , CC: Ioana Ciornei , Vadym Kochan , Taras Chornyi , Jiri Pirko , Ido Schimmel , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vignesh Raghavendra , Linus Walleij , , Vladimir Oltean , Tobias Waldekranz References: <20210414165256.1837753-1-olteanv@gmail.com> <20210414165256.1837753-3-olteanv@gmail.com> From: Grygorii Strashko Message-ID: <1aadef14-f89e-ab08-84aa-a027425d26c0@ti.com> Date: Fri, 16 Apr 2021 13:11:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210414165256.1837753-3-olteanv@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 14/04/2021 19:52, Vladimir Oltean wrote: > From: Vladimir Oltean > > As explained in bugfix commit 6ab4c3117aec ("net: bridge: don't notify > switchdev for local FDB addresses") as well as in this discussion: > https://lore.kernel.org/netdev/20210117193009.io3nungdwuzmo5f7@skbuf/ > > the switchdev notifiers for FDB entries managed to have a zero-day bug, > which was that drivers would not know what to do with local FDB entries, > because they were not told that they are local. The bug fix was to > simply not notify them of those addresses. > > Let us now add the 'is_local' bit to bridge FDB entries, and make all > drivers ignore these entries by their own choice. > > Co-developed-by: Tobias Waldekranz > Signed-off-by: Tobias Waldekranz > Signed-off-by: Vladimir Oltean > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 4 ++-- > drivers/net/ethernet/marvell/prestera/prestera_switchdev.c | 2 +- > drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 5 +++-- > drivers/net/ethernet/rocker/rocker_main.c | 4 ++-- > drivers/net/ethernet/ti/am65-cpsw-switchdev.c | 4 ++-- > drivers/net/ethernet/ti/cpsw_switchdev.c | 4 ++-- > include/net/switchdev.h | 1 + > net/bridge/br_switchdev.c | 3 +-- > net/dsa/slave.c | 2 +- > 9 files changed, 15 insertions(+), 14 deletions(-) For cpsw: Reviewed-by: Grygorii Strashko Thank you. -- Best regards, grygorii