linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rob Clark <rob.clark@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, patches@linaro.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>,
	Rob Clark <rob@ti.com>
Subject: Re: [PATCH] ARM: add get_user() support for 8 byte types
Date: Mon, 12 Nov 2012 19:27:27 +0000	[thread overview]
Message-ID: <20121112192727.GB28341@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1352495853-9790-1-git-send-email-rob.clark@linaro.org>

On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote:
> From: Rob Clark <rob@ti.com>
> 
> A new atomic modeset/pageflip ioctl being developed in DRM requires
> get_user() to work for 64bit types (in addition to just put_user()).

NAK.

(I did write a better email explaining all the ins and outs of why this
won't work and why 64-bit get_user isn't possible, but my editor crapped
out and lost all that well written message; I don't fancy typing it all
out again.)

Nevertheless,
int test_ptr(unsigned int **v, unsigned int **p)
{
        return get_user(*v, p);
}

produces a warning, and you can't get away from that if you stick 64-bit
support into get_user().

Sorry, 64-bit get_user() is a no-no.

  parent reply	other threads:[~2012-11-12 19:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 21:17 [PATCH] ARM: add get_user() support for 8 byte types Rob Clark
2012-11-12 10:46 ` Will Deacon
2012-11-12 13:46   ` Rob Clark
2012-11-12 14:38     ` Will Deacon
2012-11-12 15:09       ` Rob Clark
2012-11-12 19:27 ` Russell King - ARM Linux [this message]
2012-11-12 19:58   ` Rob Clark
2012-11-12 23:08     ` Russell King - ARM Linux
2012-11-12 23:33       ` Rob Clark
2012-11-12 23:53         ` Russell King - ARM Linux
2012-11-13  0:31           ` Rob Clark
2012-11-13  9:11             ` Arnd Bergmann
2012-11-13 11:24               ` Russell King - ARM Linux
2012-11-15  9:19                 ` Arnd Bergmann
2012-11-15 13:04                   ` Rob Clark
2012-11-15 13:39                     ` Arnd Bergmann
2012-11-15 13:46                       ` Rob Clark
2012-11-15 14:39                         ` Arnd Bergmann
2012-11-19 14:32                           ` Ville Syrjälä
2012-11-19 14:48                             ` Russell King - ARM Linux
2012-11-19 15:18                               ` Ville Syrjälä
2012-11-13 11:04             ` Russell King - ARM Linux
2012-11-13 15:00 Rob Clark
2012-11-15 22:01 Rob Clark
2012-11-15 22:22 ` Nicolas Pitre
2012-11-16  8:18 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121112192727.GB28341@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rob.clark@linaro.org \
    --cc=rob@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).