From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver Date: Fri, 16 Nov 2012 12:30:14 +0100 Message-ID: <20121116113014.GA19028@pengutronix.de> References: <1352747326-2195-1-git-send-email-aaro.koskinen@iki.fi> <1352747326-2195-2-git-send-email-aaro.koskinen@iki.fi> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Return-path: Content-Disposition: inline In-Reply-To: <1352747326-2195-2-git-send-email-aaro.koskinen@iki.fi> Sender: linux-kernel-owner@vger.kernel.org To: Aaro Koskinen Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org List-Id: linux-omap@vger.kernel.org --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 12, 2012 at 09:08:42PM +0200, Aaro Koskinen wrote: > Add i2c driver to enable access to devices behind CBUS on Nokia Internet > Tablets. >=20 > The patch also adds CBUS I2C configuration for N8x0 which is one of the > users of this driver. >=20 > Cc: linux-i2c@vger.kernel.org > Acked-by: Felipe Balbi > Acked-by: Tony Lindgren > Signed-off-by: Aaro Koskinen > Cc: Wolfram Sang Mostly good, but the devicetree binding description is missing. Please add a proper file with the same name as the driver to Documentation/devicetree/bindings/i2c. Also, it might make sense to rename the driver to i2c-cbus-gpio? Thanks, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlCmI8YACgkQD27XaX1/VRtX4QCdF84DsfMsJ9LYNWyLg7PrgTcz 0SkAn310otDcbXSGDnFFgdkor3BYk6CF =x/v1 -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--