From: Lee Jones <lee.jones@linaro.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 3/3] mfd: menelaus: use macro for magic number
Date: Mon, 30 Mar 2015 08:15:41 +0100 [thread overview]
Message-ID: <20150330071541.GJ457@x1> (raw)
In-Reply-To: <1427575537-28508-4-git-send-email-aaro.koskinen@iki.fi>
On Sat, 28 Mar 2015, Aaro Koskinen wrote:
> Use macro to check a register bit.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/mfd/menelaus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> index 917fa86..c2ca665 100644
> --- a/drivers/mfd/menelaus.c
> +++ b/drivers/mfd/menelaus.c
> @@ -1216,7 +1216,7 @@ static int menelaus_probe(struct i2c_client *client,
> err = menelaus_read_reg(MENELAUS_VCORE_CTRL1);
> if (err < 0)
> goto fail;
> - if (err & BIT(7))
> + if (err & VCORE_CTRL1_HW_NSW)
> menelaus->vcore_hw_mode = 1;
> else
> menelaus->vcore_hw_mode = 0;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-03-30 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 20:45 [PATCH 0/3] mfd: menelaus: couple simple cleanups Aaro Koskinen
2015-03-28 20:45 ` [PATCH 1/3] mfd: menelaus: delete omap_has_menelaus Aaro Koskinen
2015-03-30 7:14 ` Lee Jones
2015-03-28 20:45 ` [PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE Aaro Koskinen
2015-03-30 7:15 ` Lee Jones
2015-03-28 20:45 ` [PATCH 3/3] mfd: menelaus: use macro for magic number Aaro Koskinen
2015-03-30 7:15 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330071541.GJ457@x1 \
--to=lee.jones@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).